Skip to content

*: update the row count display of probe side of IndexJoin and Apply#10864

Merged
ti-chi-bot merged 8 commits into
pingcap:masterfrom
time-and-fate:tidb38188
Nov 15, 2022
Merged

*: update the row count display of probe side of IndexJoin and Apply#10864
ti-chi-bot merged 8 commits into
pingcap:masterfrom
time-and-fate:tidb38188

Conversation

@time-and-fate
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate commented Oct 17, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2022
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Oct 17, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 17, 2022
@qiancai qiancai added missing-translation-status This PR does not have translation status info. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.4 This PR/issue applies to TiDB v6.4. and removed translation/doing This PR's assignee is translating this PR. labels Oct 17, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 17, 2022
@qiancai qiancai added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Oct 17, 2022
@TomShawn TomShawn marked this pull request as draft November 1, 2022 07:02
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022
@hfxsd hfxsd self-requested a review November 1, 2022 07:04
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2022
@TomShawn TomShawn marked this pull request as ready for review November 11, 2022 05:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2022
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Nov 11, 2022

@time-and-fate Please sync the new changes made in pingcap/docs-cn#11624 and resolve the conflict.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2022
@time-and-fate
Copy link
Copy Markdown
Member Author

time-and-fate commented Nov 11, 2022

@TomShawn Updated. PTAL~

TomShawn
TomShawn reviewed Nov 14, 2022
View reviewed changes
Comment thread explain-joins.md Outdated
Comment thread explain-overview.md Outdated
Comment thread explain-overview.md Outdated
Comment thread explain-overview.md Outdated
Comment thread explain-overview.md Outdated
Comment thread explain-overview.md Outdated
Comment thread sql-statements/sql-statement-explain.md Outdated
@time-and-fate @TomShawn
Apply suggestions from code review
2851e55 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@time-and-fate
Copy link
Copy Markdown
Member Author

time-and-fate commented Nov 14, 2022

The ci/vale fails, but it doesn't say where is wrong.

@time-and-fate @TomShawn
Update explain-overview.md
1bcf609 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Nov 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Nov 15, 2022
View reviewed changes
Comment thread explain-overview.md
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 15, 2022
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 15, 2022

@TomShawn: /merge in this pull request requires 1 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Nov 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2022
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 15, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 919f09f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@ti-chi-bot ti-chi-bot merged commit 45da7ba into pingcap:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

@hfxsd hfxsd Awaiting requested review from hfxsd

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. for-release This PR relates to a TiDB release but does not have a tracked feature. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@time-and-fate @ti-chi-bot @TomShawn @qiancai