Skip to content

complement errors relating to lazy uniqueness check#10928

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
ekexium:update-error-message
Nov 4, 2022
Merged

complement errors relating to lazy uniqueness check#10928
ti-chi-bot merged 7 commits into
pingcap:masterfrom
ekexium:update-error-message

Conversation

@ekexium
Copy link
Copy Markdown
Member

@ekexium ekexium commented Oct 20, 2022

Signed-off-by: ekexium eke@fastmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ekexium
complement errors relating to lazy uniqueness check
50bf291 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ekexium ekexium requested a review from qiancai October 20, 2022 03:38
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2022
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4. labels Oct 20, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 20, 2022
ekexium
ekexium commented Oct 20, 2022
View reviewed changes
Comment thread constraints.md Outdated
@Oreoxmt Oreoxmt self-requested a review October 21, 2022 04:06
@qiancai qiancai self-assigned this Oct 21, 2022
dveeden
dveeden reviewed Oct 21, 2022
View reviewed changes
Comment thread constraints.md Outdated
ekexium and others added 3 commits October 21, 2022 16:27
@ekexium @dveeden
Update constraints.md
79911a3 
Co-authored-by: Daniël van Eeden <github@myname.nl>
@ekexium
remove v6.3 related stuff
ba24f33 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
Revert "remove v6.3 related stuff"
0c05850 
This reverts commit ba24f33.
Oreoxmt
Oreoxmt reviewed Oct 26, 2022
View reviewed changes
Comment thread constraints.md Outdated
@Oreoxmt Oreoxmt self-requested a review October 26, 2022 06:07
@ekexium @Oreoxmt
Update constraints.md
39edce2 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2022
@Oreoxmt Oreoxmt requested a review from dveeden October 27, 2022 05:28
qiancai
qiancai reviewed Nov 2, 2022
View reviewed changes
Comment thread constraints.md Outdated
@ekexium @qiancai
Update constraints.md
3f3e76d 
Co-authored-by: Grace Cai <qqzczy@126.com>
dveeden
dveeden approved these changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to pingcap/tidb#38243 / pingcap/tidb#38242 isn't it?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@ekexium
Copy link
Copy Markdown
Member Author

ekexium commented Nov 2, 2022

This is related to pingcap/tidb#38243 / pingcap/tidb#38242 isn't it?

Yep

@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Nov 4, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 4, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3f3e76d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@ti-chi-bot ti-chi-bot merged commit b0ea142 into pingcap:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@dveeden dveeden dveeden approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

Assignees

@qiancai qiancai

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ekexium @ti-chi-bot @qiancai @dveeden @Oreoxmt