Skip to content

Add description about user ATTRIBUTE#11084

Merged
ti-chi-bot merged 12 commits into
pingcap:masterfrom
qiancai:user_attribute
Nov 7, 2022
Merged

Add description about user ATTRIBUTE#11084
ti-chi-bot merged 12 commits into
pingcap:masterfrom
qiancai:user_attribute

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Oct 28, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.4 This PR/issue applies to TiDB v6.4. labels Oct 28, 2022
@qiancai qiancai requested a review from CbcWestwolf October 28, 2022 15:24
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2022
qiancai
qiancai commented Oct 28, 2022
View reviewed changes
Comment thread sql-statements/sql-statement-create-user.md Outdated
@qiancai qiancai self-assigned this Nov 1, 2022
qiancai
qiancai commented Nov 1, 2022
View reviewed changes
Comment thread information-schema/information-schema-user-attributes.md Outdated
@qiancai qiancai requested a review from Oreoxmt November 1, 2022 02:29
Oreoxmt
Oreoxmt reviewed Nov 1, 2022
View reviewed changes
Comment thread information-schema/information-schema.md Outdated
@Oreoxmt Oreoxmt self-requested a review November 1, 2022 05:17
@CbcWestwolf @Oreoxmt
Update information-schema/information-schema.md
45622af 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread information-schema/information-schema-user-attributes.md Outdated
Comment thread sql-statements/sql-statement-alter-user.md
Comment thread sql-statements/sql-statement-create-user.md
@CbcWestwolf @Oreoxmt
Apply suggestions from code review
cc0fcd3 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Nov 2, 2022
View reviewed changes
Comment thread sql-statements/sql-statement-alter-user.md
@Oreoxmt Oreoxmt self-requested a review November 2, 2022 08:03
Oreoxmt
Oreoxmt approved these changes Nov 7, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread information-schema/information-schema-user-attributes.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
@CbcWestwolf @Oreoxmt
Update information-schema/information-schema-user-attributes.md
3032396 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Nov 7, 2022
View reviewed changes
Comment thread information-schema/information-schema-user-attributes.md Outdated
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

@qiancai: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Nov 7, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 826c0cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 1ad8a7b into pingcap:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiancai @ti-chi-bot @CbcWestwolf @Oreoxmt