Skip to content

Add description about tidb_auth_token authentication#11119

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Oreoxmt:translate/docs-cn-11824
Nov 7, 2022
Merged

Add description about tidb_auth_token authentication#11119
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Oreoxmt:translate/docs-cn-11824

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Nov 2, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/security Relates to TiDB security and privilege. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4. labels Nov 2, 2022
@Oreoxmt Oreoxmt self-assigned this Nov 2, 2022
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2022
CbcWestwolf
CbcWestwolf approved these changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@CbcWestwolf CbcWestwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-configuration-file.md Outdated
Comment thread tidb-configuration-file.md Outdated
@Oreoxmt @CbcWestwolf
Apply suggestions from code review
9b90504 
Co-authored-by: CbcWestwolf <1004626265@qq.com>
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Nov 2, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
shichun-0415
shichun-0415 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread security-compatibility-with-mysql.md Outdated
Comment thread system-variables.md Outdated
Comment thread tidb-configuration-file.md Outdated
Comment thread tidb-configuration-file.md Outdated
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@Oreoxmt @shichun-0415
Apply suggestions from code review
47b6ef8 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 47b6ef8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit a958892 into pingcap:master Nov 7, 2022
@Oreoxmt Oreoxmt deleted the translate/docs-cn-11824 branch February 14, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

area/security Relates to TiDB security and privilege. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Oreoxmt @ti-chi-bot @CbcWestwolf @shichun-0415