Skip to content

Add description about --initialize-sql-file option#12306

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
shichun-0415:init-sql-file
Feb 8, 2023
Merged

Add description about --initialize-sql-file option#12306
ti-chi-bot merged 3 commits into
pingcap:masterfrom
shichun-0415:init-sql-file

Conversation

@shichun-0415
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 commented Jan 30, 2023

What is changed, added or deleted? (Required)

Add the description about --initialize-sql-file option and the related configuration, which is introduced in v6.6.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jan 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from qiancai January 30, 2023 09:10
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2023
@shichun-0415 shichun-0415 requested review from CbcWestwolf and Oreoxmt and removed request for qiancai January 30, 2023 09:11
@shichun-0415 shichun-0415 self-assigned this Jan 30, 2023
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jan 30, 2023
CbcWestwolf
CbcWestwolf approved these changes Jan 30, 2023
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
@shichun-0415 @CbcWestwolf
Apply suggestions from code review
3a782e6 
Co-authored-by: CbcWestwolf <1004626265@qq.com>
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Feb 2, 2023

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
Oreoxmt
Oreoxmt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread command-line-flags-for-tidb-configuration.md Outdated
Comment thread tidb-configuration-file.md Outdated
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@shichun-0415 @Oreoxmt
Apply suggestions from code review
444aa22 
Co-authored-by: Aolin <aolinz@outlook.com>
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Feb 8, 2023

/verify

@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 8, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 444aa22

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit ea6fa99 into pingcap:master Feb 8, 2023
@qiancai qiancai added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 9, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 9, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #12824.

ti-chi-bot added a commit that referenced this pull request Mar 10, 2023
@ti-chi-bot
Add description about --initialize-sql-file option (#12306) (#12824)
e48b65f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@shichun-0415 shichun-0415

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shichun-0415 @ti-chi-bot @CbcWestwolf @Oreoxmt @qiancai