Skip to content

lightning: introduce a new parameter header-schema-match#12429

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
hfxsd:add-new-lightning-parameter-header
Feb 14, 2023
Merged

lightning: introduce a new parameter header-schema-match#12429
ti-chi-bot merged 7 commits into
pingcap:masterfrom
hfxsd:add-new-lightning-parameter-header

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Feb 9, 2023

What is changed, added or deleted? (Required)

Introduced a new parameter header-schema-match.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this Feb 9, 2023
@ti-chi-bot ti-chi-bot requested a review from ran-huang February 9, 2023 02:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2023
@hfxsd hfxsd requested review from dsdashun and removed request for ran-huang February 9, 2023 02:49
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6 labels Feb 9, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Feb 9, 2023
@hfxsd hfxsd added the area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. label Feb 9, 2023
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Co-authored-by: dsdashun <dsdashun@qq.com>
@hfxsd hfxsd requested a review from qiancai February 9, 2023 05:38
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@hfxsd: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Feb 14, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: cab2816

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit 1962a15 into pingcap:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants