Skip to content

update some desc about auto-analyze#13540

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
qiancai:auto-analyze
May 22, 2023
Merged

update some desc about auto-analyze#13540
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
qiancai:auto-analyze

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented May 11, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

update some desc and format about auto-analyze

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. labels May 11, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glkappe
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2023
@qiancai qiancai requested a review from glkappe May 11, 2023 06:52
glkappe
glkappe approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glkappe
glkappe approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
qiancai
qiancai commented May 11, 2023
View reviewed changes
Comment thread keywords.md
- THAN
- THEN (R)
- TIDB (R)
- TiDB_CURRENT_TSO (R)
Copy link
Copy Markdown
Collaborator Author

@qiancai qiancai May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is from a comment in pingcap/docs-cn#13871 (comment).

qiancai
qiancai commented May 11, 2023
View reviewed changes
Comment thread statistics.md Outdated
@ti-chi-bot ti-chi-bot Bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented May 22, 2023

/verify

@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented May 22, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e1fdac9

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@ti-chi-bot ti-chi-bot Bot merged commit fda8683 into pingcap:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfxsd hfxsd hfxsd approved these changes

+2 more reviewers

@glkappe glkappe glkappe approved these changes

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiancai @glkappe @hfxsd @ran-huang