Add deprecate-integer-display-length to TIDB Config#14718
Merged
Conversation
ti-chi-bot
Bot
added
missing-translation-status
ran-huang
reviewed
Sep 7, 2023
Co-authored-by: Ran <huangran.alex@gmail.com>
ran-huang
approved these changes
Sep 7, 2023
Oreoxmt
approved these changes
Sep 7, 2023
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ran-huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ran-huang
added
translation/doing
ti-chi-bot
Bot
added
approved
and removed
missing-translation-status
17 tasks
ran-huang
added
translation/done
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Added docs for the undocumented
deprecate-integer-display-lengthoption.See also: https://github.com/pingcap/tidb/blob/302786ffb91400f30d0be90abaca852a73ffa41c/config/config.toml.example#L102-L104
Note that I also filed a bug that is related to this issue: pingcap/tidb#46650
Also related: pingcap/tidb#18775
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?