Skip to content

explain joins: fix the TableReader operator#14929

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
Oreoxmt:fix/explain-joins
Sep 27, 2023
Merged

explain joins: fix the TableReader operator#14929
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
Oreoxmt:fix/explain-joins

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Sep 27, 2023

What is changed, added or deleted? (Required)

Keep the description of TableReader ID to be consistent with the output.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. labels Sep 27, 2023
@Oreoxmt Oreoxmt self-assigned this Sep 27, 2023
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2023
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Sep 27, 2023
@Oreoxmt Oreoxmt requested a review from qiancai September 27, 2023 03:15
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 27, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 03:15:46.04253947 +0000 UTC m=+417535.760881688: ☑️ agreed by qiancai.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 27, 2023

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added the lgtm label Sep 27, 2023
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Sep 27, 2023

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot Bot merged commit d21f15e into pingcap:master Sep 27, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14935.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14936.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14937.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #14938.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: cannot checkout release-7.4: error checking out release-7.4: exit status 1. output: error: pathspec 'release-7.4' did not match any file(s) known to git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants