Skip to content

ebnf user variable#17047

Merged
ti-chi-bot[bot] merged 6 commits into
pingcap:masterfrom
dveeden:ebnf_set_variable
Apr 15, 2024
Merged

ebnf user variable#17047
ti-chi-bot[bot] merged 6 commits into
pingcap:masterfrom
dveeden:ebnf_set_variable

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 8, 2024

What is changed, added or deleted? (Required)

Closes #17046

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and kennytm April 8, 2024 15:20
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Apr 8, 2024

Using ":=" and multiple variables all works in TiDB:

sql> SET GLOBAL max_connections := 500, tidb_use_plan_baselines := ON;
Query OK, 0 rows affected (0.0004 sec)

There is an alternative SET @@global.max_connections = 500. Not sure if we should add that.

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 9, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt removed their request for review April 10, 2024 09:47
Comment thread sql-statements/sql-statement-set-variable.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 12, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 03:52:37.459327463 +0000 UTC m=+1193618.986868002: ☑️ agreed by hfxsd.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2024
Comment thread sql-statements/sql-statement-set-variable.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Apr 15, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 256275c into pingcap:master Apr 15, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17192.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
17 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request Apr 15, 2024
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql-statements/sql-statement-set-variable.md

5 participants