Skip to content

ebnf savepoint#17083

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:ebnf_savepoint
Apr 18, 2024
Merged

ebnf savepoint#17083
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:ebnf_savepoint

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 9, 2024

What is changed, added or deleted? (Required)

Add EBNF for SAVEPOINT related statements

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Apr 9, 2024
@dveeden dveeden requested review from Oreoxmt and kennytm April 9, 2024 08:47
@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2024
dveeden
dveeden commented Apr 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this page documents multiple statements instead of a single one. Should we split this into multiple pages? Or add links like we do for "SHOW SCHEMAS" and "SHOW DATABASES"?

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 9, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt removed their request for review April 10, 2024 09:45
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.0 labels Apr 17, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Apr 17, 2024
qiancai
qiancai reviewed Apr 18, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-savepoint.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 18, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 02:25:09.860818184 +0000 UTC m=+477728.971864633: ☑️ agreed by qiancai.

@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Apr 18, 2024

/approve

@qiancai qiancai added the lgtm label Apr 18, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 18, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 24e264c into pingcap:master Apr 18, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 18, 2024

In response to a cherrypick label: new pull request created to branch release-8.0: #17241.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2024
Merged
17 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request Apr 19, 2024
@ti-chi-bot
ebnf savepoint (#17083) (#17241)
6b28a55
@qiancai qiancai mentioned this pull request Apr 25, 2024
Merged
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 29, 2024
Merged
17 tasks
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
ebnf savepoint (pingcap#17083)
d658364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dveeden @qiancai @ti-chi-bot @kennytm