Skip to content

Fix EBNF for SHOW WARNINGS#17156

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
dveeden:ebnf_fix_show_warning
Apr 12, 2024
Merged

Fix EBNF for SHOW WARNINGS#17156
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
dveeden:ebnf_fix_show_warning

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 11, 2024 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

The EBNF for SHOW WARNINGS isn't formatted correctly

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and kennytm April 11, 2024 07:40
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2024
@Oreoxmt Oreoxmt requested review from lilin90 and removed request for Oreoxmt April 11, 2024 08:02
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 11, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 12, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 03:36:22.360535044 +0000 UTC m=+1192643.888075590: ☑️ agreed by lilin90.

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Apr 12, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 12, 2024
@lilin90 lilin90 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 translation/no-need No need to translate this PR. labels Apr 12, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Apr 12, 2024
@lilin90 lilin90 mentioned this pull request Apr 12, 2024
Closed
17 tasks
@lilin90 lilin90 added the lgtm label Apr 12, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 45ac1f0 into pingcap:master Apr 12, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 12, 2024

In response to a cherrypick label: new pull request created to branch release-8.0: #17167.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 12, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #17168.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2024
Merged
17 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request Apr 12, 2024
@ti-chi-bot
Fix EBNF for SHOW WARNINGS (#17156) (#17167)
8180ef9
ti-chi-bot Bot pushed a commit that referenced this pull request Apr 12, 2024
@ti-chi-bot
Fix EBNF for SHOW WARNINGS (#17156) (#17168)
87cc713
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Fix EBNF for SHOW WARNINGS (pingcap#17156)
415f716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@lilin90 lilin90

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dveeden @lilin90 @ti-chi-bot @kennytm