Skip to content

*: change all "http" to "https" in http://download.pingcap.org/#1751

Merged
lilin90 merged 2 commits into
pingcap:masterfrom
yikeke:change-http-to-https
Jan 8, 2020
Merged

*: change all "http" to "https" in http://download.pingcap.org/#1751
lilin90 merged 2 commits into
pingcap:masterfrom
yikeke:change-http-to-https

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jan 8, 2020

What is changed, added or deleted?

Change Every http://download.pingcap.org/ to https://download.pingcap.org/.

There is no 301 redirect from HTTP to HTTPS on download.pingcap.org, fixing this would significantly improve security on downloading from our sites.

What is the related PR or file link(s)?

pingcap/docs-cn#2165

Which version does your change affect?

all

@yikeke yikeke added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jan 8, 2020
@yikeke yikeke changed the title *: change http to https *: change all "http" to "https" in http://download.pingcap.org/ Jan 8, 2020
@WangXiangUSTC
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 421ef1e into pingcap:master Jan 8, 2020
@yikeke yikeke deleted the change-http-to-https branch January 8, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants