Skip to content

how-to/get-started: change tispark-sample-data download address#1780

Closed
jrbase wants to merge 1 commit into
pingcap:masterfrom
kana112233:patch-1
Closed

how-to/get-started: change tispark-sample-data download address#1780
jrbase wants to merge 1 commit into
pingcap:masterfrom
kana112233:patch-1

Conversation

@jrbase
Copy link
Copy Markdown

@jrbase jrbase commented Jan 17, 2020

What is changed, added or deleted?

changed: v3.0/how-to/get-start/tispark.md

did: changed tispark-sample-data download link
why: can't find the TiSpark sample data in the TiDB Ansible directory

What is the related PR or file link(s)?

N/A

  • Reference link(s):
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.
dev

  • Updated one version first. Will update other versions after I get two LGTMs.

The obtained address is wrong about "tispark-sample-data"
@lilin90 lilin90 added contribution This PR is from a community contributor. translation/doing This PR's assignee is translating this PR. labels Jan 19, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jan 19, 2020

@jrbase Thanks for your contribution! @guliangliangatpingcap PTAL~

Copy link
Copy Markdown

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Does this change apply to other versions such as v2.1, v3.1, dev? If yes, please also update them. Thanks!

  • Please resolve the conflict.

```

- TiSpark sample data and import scripts are deployed by default in the TiDB Ansible directory.
- TiSpark sample data and import scripts can download [here](http://download.pingcap.org/tispark-sample-data.tar.gz).
Copy link
Copy Markdown
Member

@lilin90 lilin90 Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- TiSpark sample data and import scripts can download [here](http://download.pingcap.org/tispark-sample-data.tar.gz).
- TiSpark sample data and import scripts can be downloaded [here](http://download.pingcap.org/tispark-sample-data.tar.gz).

@lilin90 lilin90 changed the title fix: dev/how-to/get-start/tispark: change tispark-sample-data download address how-to/get-started: change tispark-sample-data download address Feb 10, 2020
@lilin90 lilin90 added the size/small Changes of a small size. label Feb 10, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Feb 24, 2020

Since the upstream structure of the docs repo has greatly changed, and the reviewers are also unable to push any commit to this PR due to an unknown error, I'll close this PR and migrate the changes to #1861.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants