Skip to content

reference: add error codes#1816

Merged
lilin90 merged 12 commits into
pingcap:masterfrom
ran-huang:update_error_code
Feb 21, 2020
Merged

reference: add error codes#1816
lilin90 merged 12 commits into
pingcap:masterfrom
ran-huang:update_error_code

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted?

Add error codes in dev/reference.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@ran-huang ran-huang added dev translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. labels Feb 19, 2020
@ran-huang ran-huang requested review from jackysp and lilin90 February 19, 2020 10:37
Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md
Co-Authored-By: Jack Yu <yusp@pingcap.com>
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Copy Markdown
Contributor Author

@lilin90 PTAL~

Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md Outdated
Comment thread dev/reference/error-codes.md Outdated
@ran-huang
Copy link
Copy Markdown
Contributor Author

@lilin90 Thanks. All suggestions applied. PTAL~

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit ff66748 into pingcap:master Feb 21, 2020
@ran-huang ran-huang deleted the update_error_code branch February 24, 2020 01:48
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
* reference: add error codes

WIP

* Update error-codes.md

* Update error-codes.md

* Update error-codes.md

* reference: revise terms

* reference: update minor change in error-codes

* reference: minor change in error-codes

* change choice of words

Co-Authored-By: Jack Yu <yusp@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Replace illegal with invalid

Co-authored-by: Jack Yu <yusp@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants