tidb: add explanation for the fields in `mysql.user` by CbcWestwolf · Pull Request #18318 · pingcap/docs

CbcWestwolf · 2024-07-22T06:02:39Z

What is changed, added or deleted? (Required)

add explanation for the fields in mysql.user
put mysql-schema*.md in a unique dir

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

dveeden

It might be good to put a reminder on this page that these are system tables and that it is not recommended to change them directly. The recommended way is to use CREATE USER/ALTER USER/DROP USER/GRANT/REVOKE/SHOW CREATE USER etc.
When people still want to make changes to these tables directly they should run FLUSH PRIVILEGES.
Do we want/need to put in a statement about what is MySQL compatible and what's not?
Would still be good to have a page per table instead of one page for all tables combined. Just like information_schema descriptions.

Co-authored-by: Daniël van Eeden <github@myname.nl>

ti-chi-bot · 2024-07-22T07:00:15Z

@dveeden: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Daniël van Eeden <github@myname.nl>

Co-authored-by: Aolin <aolinz@outlook.com>

ti-chi-bot · 2024-07-25T06:37:19Z

[LGTM Timeline notifier]

Timeline:

2024-07-22 06:11:21.607350432 +0000 UTC m=+852703.598291901: ☑️ agreed by dveeden.
2024-07-25 06:37:18.224016212 +0000 UTC m=+1113460.214957681: ☑️ agreed by Oreoxmt.

lilin90

/lgtm

Oreoxmt · 2024-07-29T10:14:27Z

/approve

ti-chi-bot · 2024-07-29T10:14:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Oreoxmt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-07-29T10:15:27Z

In response to a cherrypick label: new pull request created to branch release-8.1: #18417.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

tidb: add explanation for the fields in mysql.user

6349d19

ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024

CbcWestwolf requested review from Oreoxmt, dveeden and tiancaiamao July 22, 2024 06:03

Oreoxmt self-assigned this Jul 22, 2024

Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 22, 2024

ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jul 22, 2024

dveeden approved these changes Jul 22, 2024

View reviewed changes

Comment thread mysql-schema.md Outdated

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 22, 2024

CbcWestwolf and others added 4 commits July 22, 2024 14:22

Update mysql-schema.md

dbe3a43

Co-authored-by: Daniël van Eeden <github@myname.nl>

create mysql-schema dir

edd1b27

put a reminder

f0816ef

describe mysql compatibility

696168a

ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024

CbcWestwolf force-pushed the mysql-user branch 2 times, most recently from 06a3e1d to 597aef8 Compare July 22, 2024 06:49

fix

334e085

CbcWestwolf force-pushed the mysql-user branch from 597aef8 to 334e085 Compare July 22, 2024 06:50

dveeden approved these changes Jul 22, 2024

View reviewed changes

Comment thread mysql-schema/mysql-schema.md Outdated

Update mysql-schema/mysql-schema.md

2bc487f

Co-authored-by: Daniël van Eeden <github@myname.nl>

CbcWestwolf force-pushed the mysql-user branch from db79f3a to 2bc487f Compare July 22, 2024 08:03

dveeden reviewed Jul 22, 2024

View reviewed changes

Comment thread mysql-schema/mysql-schema-user.md Outdated

dveeden reviewed Jul 22, 2024

View reviewed changes

Comment thread mysql-schema/mysql-schema-user.md Outdated

dveeden reviewed Jul 22, 2024

View reviewed changes

Comment thread mysql-schema/mysql-schema-user.md Outdated

Oreoxmt reviewed Jul 23, 2024

View reviewed changes

Apply suggestions from code review

d776a3a

Co-authored-by: Aolin <aolinz@outlook.com>

Oreoxmt self-requested a review July 24, 2024 08:24

Oreoxmt added 4 commits July 25, 2024 14:05

Merge branch 'master' into mysql-user

ee00df1

fix links for mysql.user

c43717f

fix links for mysql schema

f2f8284

fix format

3857870

Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 25, 2024

Oreoxmt mentioned this pull request Jul 25, 2024

tidb: add explanation for the fields in mysql.user pingcap/docs-cn#18118

Merged

16 tasks

Oreoxmt approved these changes Jul 25, 2024

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 25, 2024

tiancaiamao approved these changes Jul 25, 2024

View reviewed changes

Oreoxmt requested a review from lilin90 July 26, 2024 02:40

lilin90 reviewed Jul 29, 2024

View reviewed changes

Comment thread mysql-schema/mysql-schema-user.md Outdated

Update wording

029116c

lilin90 approved these changes Jul 29, 2024

View reviewed changes

ti-chi-bot Bot added the approved label Jul 29, 2024

ti-chi-bot Bot merged commit bb01d49 into pingcap:master Jul 29, 2024

ti-chi-bot mentioned this pull request Jul 29, 2024

tidb: add explanation for the fields in mysql.user (#18318) #18417

Merged

16 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024

This is an automated cherry-pick of pingcap#18318

6940107

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024

tidb: add explanation for the fields in mysql.user (pingcap#18318)

793e1cb

ti-chi-bot mentioned this pull request Jul 29, 2024

tidb: add explanation for the fields in mysql.user (#18118) pingcap/docs-cn#18199

Merged

16 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Jul 29, 2024

tidb: add explanation for the fields in mysql.user (#18318) (#18417)

773e1d9

CbcWestwolf deleted the mysql-user branch July 30, 2024 08:29

Conversation

CbcWestwolf commented Jul 22, 2024 • edited by Oreoxmt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

dveeden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jul 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jul 25, 2024

[LGTM Timeline notifier]

Uh oh!

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

Oreoxmt commented Jul 29, 2024

Uh oh!

ti-chi-bot Bot commented Jul 29, 2024

Uh oh!

ti-chi-bot commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CbcWestwolf commented Jul 22, 2024 •

edited by Oreoxmt

Loading