Skip to content

Update DDL descriptions in cluster upgrade#18453

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
lilin90:upgrade-ddl-18239
Aug 5, 2024
Merged

Update DDL descriptions in cluster upgrade#18453
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
lilin90:upgrade-ddl-18239

Conversation

@lilin90
Copy link
Copy Markdown
Member

@lilin90 lilin90 commented Aug 2, 2024

What is changed, added or deleted? (Required)

Updates DDL descriptions when using smooth upgrade. This PR is a follow-up to #18332.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement. labels Aug 2, 2024
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2024
@lilin90 lilin90 self-assigned this Aug 2, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Aug 2, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread upgrade-tidb-using-tiup.md Outdated
Comment thread upgrade-tidb-using-tiup.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 10:17:00.958117875 +0000 UTC m=+1550.825216963: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@lilin90 lilin90 added the lgtm label Aug 5, 2024
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented Aug 5, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 5, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 1552e16 into pingcap:master Aug 5, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18463.

@lilin90 lilin90 deleted the upgrade-ddl-18239 branch August 5, 2024 03:13
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18464.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18465.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18466.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #18467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants