Skip to content

best-practices: fix a typo (#1948)#1950

Merged
sre-bot merged 1 commit into
pingcap:release-3.1from
sre-bot:release-3.1-db3763ee7773
Mar 5, 2020
Merged

best-practices: fix a typo (#1948)#1950
sre-bot merged 1 commit into
pingcap:release-3.1from
sre-bot:release-3.1-db3763ee7773

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Mar 5, 2020

cherry-pick #1948 to release-3.1


What is changed, added or deleted? (Required)

Fix a typo.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@sre-bot sre-bot mentioned this pull request Mar 5, 2020
4 tasks
@sre-bot sre-bot added the type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. label Mar 5, 2020
@sre-bot sre-bot requested review from lilin90 and toutdesuite March 5, 2020 04:06
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2020
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Mar 5, 2020

Your auto merge job has been accepted, waiting for 1949

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Mar 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit fe65d15 into pingcap:release-3.1 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants