tiflash: add use-tiflash doc#2163
Merged
Merged
Conversation
TomShawn
added
translation/from-docs-cn
4 tasks
ran-huang
reviewed
Apr 3, 2020
Co-Authored-By: Ran <huangran@pingcap.com>
Contributor
Author
|
@ran-huang @ilovesoup Comment addressed, PTAL again, thanks! |
ilovesoup
approved these changes
Apr 6, 2020
Contributor
ilovesoup
left a comment
ilovesoup
left a comment
There was a problem hiding this comment.
Made my change and LGTM
Co-Authored-By: Ran <huangran@pingcap.com>
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 7, 2020
* tiflash: add use-tiflash doc * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * use unordered list * fix typos * Update use-tiflash.md * Update reference/tiflash/use-tiflash.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
4 tasks
Contributor
|
cherry pick to release-3.1 in PR #2173 |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 7, 2020
* tiflash: add use-tiflash doc * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * use unordered list * fix typos * Update use-tiflash.md * Update reference/tiflash/use-tiflash.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
4 tasks
Contributor
|
cherry pick to release-4.0 in PR #2174 |
yikeke
added a commit
that referenced
this pull request
Apr 7, 2020
* tiflash: add use-tiflash doc * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * use unordered list * fix typos * Update use-tiflash.md * Update reference/tiflash/use-tiflash.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
added a commit
that referenced
this pull request
Apr 7, 2020
* tiflash: add use-tiflash doc * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * use unordered list * fix typos * Update use-tiflash.md * Update reference/tiflash/use-tiflash.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
This was referenced Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add
Use TiFlashdocument.Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?