Skip to content

TiFlash: add monitor.md doc#2180

Merged
TomShawn merged 7 commits into
pingcap:masterfrom
ran-huang:tiflash-monitor
Apr 8, 2020
Merged

TiFlash: add monitor.md doc#2180
TomShawn merged 7 commits into
pingcap:masterfrom
ran-huang:tiflash-monitor

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Add monitor.md for TiFlash.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.1 labels Apr 7, 2020
@ran-huang ran-huang requested a review from yikeke April 7, 2020 04:37
@yikeke yikeke requested a review from ilovesoup April 7, 2020 05:24
@yikeke yikeke assigned TomShawn and unassigned TomShawn Apr 7, 2020
@yikeke yikeke requested a review from TomShawn April 7, 2020 10:36
Copy link
Copy Markdown
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread reference/tiflash/monitor.md Outdated
Comment thread TOC.md Outdated
ran-huang and others added 3 commits April 7, 2020 21:09
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Copy Markdown
Contributor Author

@TomShawn PTAL again~

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit d2500b4 into pingcap:master Apr 8, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 8, 2020
* Create monitor.md

* tiflash: add monitor doc

* TOC: add monitor.md

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* add backquotes

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 8, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 8, 2020

cherry pick to release-3.1 in PR #2192

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 8, 2020
* Create monitor.md

* tiflash: add monitor doc

* TOC: add monitor.md

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* add backquotes

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 8, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 8, 2020

cherry pick to release-4.0 in PR #2193

sre-bot added a commit that referenced this pull request Apr 8, 2020
@ran-huang ran-huang deleted the tiflash-monitor branch April 8, 2020 03:32
sre-bot added a commit that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants