Skip to content

tiflash: add scale.md doc#2184

Merged
yikeke merged 11 commits into
pingcap:masterfrom
ran-huang:tiflash-scale
Apr 8, 2020
Merged

tiflash: add scale.md doc#2184
yikeke merged 11 commits into
pingcap:masterfrom
ran-huang:tiflash-scale

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Add scale.md doc for TiFlash.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.1 labels Apr 7, 2020
@ran-huang ran-huang requested review from ilovesoup and yikeke April 7, 2020 07:59
Comment thread reference/tiflash/scale.md Outdated
>
> The offline process described in this section does not delete the data on the offline node. If you need to take the node online again, delete the data manually.

1. Take the node to be scaled in offline. See [Take TiFlash nodes offline](/reference/tiflash/maintain.md#take-tiflash-nodes-offline) for details.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference anchor is not finalized since the translation of maintain.md is not finished yet.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ran-huang The anchor is decided: #take-a-tiflash-node-down.

Copy link
Copy Markdown
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies only to 3.1.
4.0 will have different content.

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Apr 8, 2020

This applies only to 3.1.
4.0 will have different content.

The 4.0 changes might refer to pingcap/docs-cn#2641.

Comment thread reference/tiflash/scale.md Outdated
Comment thread reference/tiflash/scale.md Outdated
Comment thread reference/tiflash/scale.md Outdated
Comment thread reference/tiflash/scale.md Outdated
ran-huang and others added 2 commits April 8, 2020 13:38
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Copy Markdown
Contributor Author

@TomShawn PTAL again~

Comment thread TOC.md Outdated
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread reference/tiflash/scale.md Outdated
Comment thread reference/tiflash/scale.md Outdated
@ran-huang
Copy link
Copy Markdown
Contributor Author

@TomShawn PTAL

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Apr 8, 2020

I will merge this PR after #2189 is merged.

@yikeke yikeke merged commit f59fd06 into pingcap:master Apr 8, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 8, 2020
* tiflash: add scale.md doc

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update TOC.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* minor update

* update anchor

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 8, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 8, 2020

cherry pick to release-3.1 in PR #2209

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Apr 8, 2020

A dead link is introduced by this PR but it will be fixed by #2189 soon.

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 8, 2020
* tiflash: add scale.md doc

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update TOC.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* minor update

* update anchor

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 8, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 8, 2020

cherry pick to release-4.0 in PR #2210

yikeke added a commit that referenced this pull request Apr 8, 2020
* tiflash: add scale.md doc

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update TOC.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* minor update

* update anchor

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke added a commit that referenced this pull request Apr 8, 2020
* tiflash: add scale.md doc

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update TOC.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* minor update

* update anchor

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ran-huang ran-huang deleted the tiflash-scale branch April 9, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants