tiflash: add tiflash configuration document#2188
Merged
Merged
Conversation
TomShawn
added
translation/from-docs-cn
ran-huang
reviewed
Apr 7, 2020
| service_addr = The listening address of TiFlash Raft services and coprocessor services. | ||
| ``` | ||
|
|
||
| Multiple TiFlash nodes elect a master to add or delete placement rules to PD and you need three parameters to control this process. |
Contributor
There was a problem hiding this comment.
Suggested change
| Multiple TiFlash nodes elect a master to add or delete placement rules to PD and you need three parameters to control this process. | |
| Multiple TiFlash nodes elect a master to add or delete placement rules to PD, and you need three parameters to control this process. |
Contributor
Author
|
@ran-huang PTAL again, thanks! |
ran-huang
reviewed
Apr 8, 2020
Co-Authored-By: Ran <huangran@pingcap.com>
ran-huang
approved these changes
Apr 8, 2020
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 8, 2020
* tiflash: add tiflash configuration document * address comments * Update configuration.md * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-3.1 in PR #2196 |
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2197 |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 8, 2020
* tiflash: add tiflash configuration document * address comments * Update configuration.md * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
yikeke
pushed a commit
that referenced
this pull request
Apr 8, 2020
* tiflash: add tiflash configuration document * address comments * Update configuration.md * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add TiFlash configuration document.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?