Skip to content

tiflash: add the faq.md doc#2215

Merged
sre-bot merged 10 commits into
pingcap:masterfrom
toutdesuite:tiflash-faq
Apr 10, 2020
Merged

tiflash: add the faq.md doc#2215
sre-bot merged 10 commits into
pingcap:masterfrom
toutdesuite:tiflash-faq

Conversation

@toutdesuite
Copy link
Copy Markdown
Contributor

@toutdesuite toutdesuite commented Apr 9, 2020

What is changed, added or deleted? (Required)

add the add faq.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@toutdesuite toutdesuite requested review from ilovesoup and yikeke April 9, 2020 03:30
@toutdesuite toutdesuite added needs-cherry-pick-3.1 priority/P2 The issue has P2 priority. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 9, 2020
Comment thread reference/tiflash/faq.md Outdated

## Should I use TiSpark or TiDB server for a query?

It is recommended to use TiDB server if you query single table collection or you use the filtering query, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins.
Copy link
Copy Markdown
Contributor Author

@toutdesuite toutdesuite Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilovesoup Please confirm whether "It is recommended to use TiDB server if you query single table collection or you use the filtering query, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins." means the same thing with "如果查询以单表集合和过滤为主,那么 TiDB server 比 TiSpark 在列存上拥有更好的性能;如果查询以表连接为主,那么推荐使用 TiSpark。" Thanks a lot!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use TiDB server if you query single table with filtering and aggregation, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I made a mistake in Chinese version: "以单表集合和过滤" -> "以单表聚合和过滤"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilovesoup The file is updated according to your comment. Thanks!

@yikeke yikeke changed the title tiflash: add the add faq.md tiflash: add the faq.md doc Apr 9, 2020
Copy link
Copy Markdown
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread reference/tiflash/faq.md Outdated

## Should I use TiSpark or TiDB server for a query?

It is recommended to use TiDB server if you query single table collection or you use the filtering query, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use TiDB server if you query single table with filtering and aggregation, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins.

Comment thread reference/tiflash/faq.md Outdated

## Should I use TiSpark or TiDB server for a query?

It is recommended to use TiDB server if you query single table collection or you use the filtering query, because TiDB server shows better performance on the columnar storage. It is recommended to use TiSpark if you query table joins.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I made a mistake in Chinese version: "以单表集合和过滤" -> "以单表聚合和过滤"

@yikeke yikeke requested a review from TomShawn April 10, 2020 00:49
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
Comment thread reference/tiflash/faq.md Outdated
@toutdesuite
Copy link
Copy Markdown
Contributor Author

@TomShawn PTAL again. Thanks!

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit 00375a5 into pingcap:master Apr 10, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 10, 2020
@sre-bot sre-bot mentioned this pull request Apr 10, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 10, 2020

cherry pick to release-3.1 in PR #2241

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 10, 2020
@sre-bot sre-bot mentioned this pull request Apr 10, 2020
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 10, 2020

cherry pick to release-4.0 in PR #2242

TomShawn pushed a commit that referenced this pull request Apr 10, 2020
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
TomShawn pushed a commit that referenced this pull request Apr 10, 2020
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
@toutdesuite toutdesuite deleted the tiflash-faq branch April 10, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P2 The issue has P2 priority. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants