how-to: add doc on how to scale with TiUP#2239
Merged
Merged
Conversation
ran-huang
added
translation/from-docs-cn
Contributor
Author
|
@wyuchen007 @superlzs0476 |
ran-huang
commented
Apr 10, 2020
yikeke
reviewed
Apr 11, 2020
yikeke
reviewed
Apr 11, 2020
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Contributor
Author
|
@yikeke Comments addressed. PTAL, thanks~ |
Contributor
|
For the steps, suggest adjusting the headings to ordered lists. |
Contributor
Author
|
@yikeke Updated the numbered list. PTAL~ |
Contributor
|
/merge |
sre-bot
added
the
status/can-merge
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-4.0 in PR #2256 |
yikeke
added a commit
that referenced
this pull request
Apr 13, 2020
* how-to: add doc on how to scale with TiUP (#2239) * update toc anchor * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
5 tasks
yikeke
reviewed
May 19, 2020
Comment on lines
+3
to
+4
| summary: | ||
| Category: how-to |
Contributor
There was a problem hiding this comment.
summary: xxx
category: how-to
aliases: ['/docs/stable/how-to/scale/with-tiup/']
Contributor
There was a problem hiding this comment.
@ran-huang Please open a PR to fix the meta info, and we can merge the PR after the doc special week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add doc on how to scale with TiUP.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?