Skip to content

tiflash: add the alert-rules.md (#2191)#2243

Merged
sre-bot merged 1 commit into
pingcap:release-3.1from
sre-bot:release-3.1-ffcf83ec31e3
Apr 10, 2020
Merged

tiflash: add the alert-rules.md (#2191)#2243
sre-bot merged 1 commit into
pingcap:release-3.1from
sre-bot:release-3.1-ffcf83ec31e3

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Apr 10, 2020

cherry-pick #2191 to release-3.1


What is changed, added or deleted? (Required)

add the alert-rules.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

* add the alert-rules.md

* address comments

* Apply suggestions from code review

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Apr 10, 2020
5 tasks
@sre-bot sre-bot added priority/P2 The issue has P2 priority. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 10, 2020
@sre-bot sre-bot requested review from ilovesoup and yikeke April 10, 2020 08:03
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Apr 10, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Apr 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5007744 into pingcap:release-3.1 Apr 10, 2020
toutdesuite added a commit to toutdesuite/docs that referenced this pull request May 6, 2020
…ingcap#2035)

* cherry pick pingcap#1860 to release-2.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict and align pingcap#2243

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Co-authored-by: TomShawn <1135243111@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P2 The issue has P2 priority. status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants