Skip to content

reference: add more descriptions to readpool.unified#2295

Merged
sre-bot merged 3 commits into
pingcap:masterfrom
sticnarf:more-description-to-unified
Apr 16, 2020
Merged

reference: add more descriptions to readpool.unified#2295
sre-bot merged 3 commits into
pingcap:masterfrom
sticnarf:more-description-to-unified

Conversation

@sticnarf
Copy link
Copy Markdown
Contributor

Signed-off-by: Yilin Chen sticnarf@gmail.com

What is changed, added or deleted? (Required)

Add more descriptions to the unified read pool. It would help users understand better.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

## readpool.unified

Configuration items related to the single thread pool serving read requests.
Configuration items related to the single thread pool serving read requests. This thread pool supersedes the original storage thread pool and coprocessor thread pool in the 4.0 version.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Configuration items related to the single thread pool serving read requests. This thread pool supersedes the original storage thread pool and coprocessor thread pool in the 4.0 version.
Configuration items related to the single thread pool serving read requests. This thread pool supersedes the original storage thread pool and coprocessor thread pool since the 4.0 version.

@TomShawn TomShawn added size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Apr 16, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf requested a review from youjiali1995 April 16, 2020 07:56
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit dd19a4e into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 16, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #2300

sre-bot added a commit that referenced this pull request Apr 16, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants