*: change blacklist to blocklist, whitelist to allowlist#2782
Merged
Conversation
ran-huang
added
requires-version-specific-changes
lilin90
reviewed
Jun 11, 2020
Comment on lines
51
to
53
| 1. Insert the function or operator name and the collection of storage types to be prohibited from the function pushdown to `mysql.expr_pushdown_blacklist`. | ||
|
|
||
| 2. Execute the `admin reload expr_pushdown_blacklist;` command. |
Member
There was a problem hiding this comment.
It seems that we need to modify words in the two steps first, to keep consistency and avoid confusion.
Signed-off-by: Ran <huangran@pingcap.com>
ran-huang
added
translation/no-need
Contributor
Author
|
@lilin90 I think this PR is ready for merge. PTAL, thanks! Also, I removed the |
Member
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3487 |
ti-srebot
added a commit
that referenced
this pull request
Jul 30, 2020
This was referenced Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Change blacklist to blocklist, whitelist to allowlist.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?