Skip to content

update pessimistic transaction#2827

Merged
ti-srebot merged 4 commits into
pingcap:masterfrom
ran-huang:pessimistic-txn
Jun 16, 2020
Merged

update pessimistic transaction#2827
ti-srebot merged 4 commits into
pingcap:masterfrom
ran-huang:pessimistic-txn

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Update pessimistic transaction.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 12, 2020
@ran-huang ran-huang requested review from yikeke and youjiali1995 June 12, 2020 08:27
@yikeke yikeke requested a review from jackysp June 12, 2020 08:41
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Jun 15, 2020
@ran-huang
Copy link
Copy Markdown
Contributor Author

@jackysp @yikeke PTAL. Thanks~

Copy link
Copy Markdown

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 15, 2020

Good job! Please resolve comments above, rest LGTM

@yikeke yikeke added status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. labels Jun 16, 2020
ran-huang and others added 2 commits June 16, 2020 10:28
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4fdda37 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #2883

ran-huang added a commit that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the pessimistic-txn branch June 16, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants