Skip to content

update several document related to privilege sql statement#2828

Merged
ti-srebot merged 13 commits into
pingcap:masterfrom
imtbkcat:privilegeEnglish
Jun 16, 2020
Merged

update several document related to privilege sql statement#2828
ti-srebot merged 13 commits into
pingcap:masterfrom
imtbkcat:privilegeEnglish

Conversation

@imtbkcat
Copy link
Copy Markdown

@imtbkcat imtbkcat commented Jun 12, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@imtbkcat imtbkcat added the status/PTAL This PR is ready for reviewing. label Jun 12, 2020
@yikeke yikeke requested review from yikeke and zz-jason June 12, 2020 09:11
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 12, 2020
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jun 12, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 12, 2020

/run-all-tests

Comment thread sql-statements/sql-statement-create-user.md Outdated
Comment thread sql-statements/sql-statement-create-user.md Outdated
Comment thread sql-statements/sql-statement-create-user.md Outdated
Comment thread sql-statements/sql-statement-create-user.md Outdated
Comment thread sql-statements/sql-statement-create-user.md Outdated
Comment thread sql-statements/sql-statement-drop-user.md Outdated
Comment thread sql-statements/sql-statement-flush-privileges.md Outdated
Comment thread sql-statements/sql-statement-grant-privileges.md Outdated
Comment thread sql-statements/sql-statement-revoke-privileges.md Outdated
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 14, 2020

@zz-jason, @yikeke, PTAL.

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 15, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 15, 2020

Please resolve comments. @imtbkcat

Lingyu Song and others added 10 commits June 16, 2020 14:13
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 2813
  • 2790
  • 2889

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 318956d into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #2903

ti-srebot added a commit that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants