update several sql statement docs#2836
Merged
Merged
Conversation
Contributor
|
@zimulala, @djshow832, @yikeke, PTAL. |
yikeke
reviewed
Jun 15, 2020
Comment on lines
-22
to
-24
| **CharsetKw:** | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
These three lines should not be deleted according to https://github.com/pingcap/docs-cn/pull/3294/files.
| > **Note:** TiDB currently only supports binary collations. | ||
| > **Note:** | ||
| > | ||
| > Results of `SHOW COLLATION` changes with the fact whether the "new collation framework" is enabled, detailed information of "new collation framework" can be found in [Character Set and Collation](/character-set-and-collation.md)) |
Contributor
There was a problem hiding this comment.
Suggested change
| > Results of `SHOW COLLATION` changes with the fact whether the "new collation framework" is enabled, detailed information of "new collation framework" can be found in [Character Set and Collation](/character-set-and-collation.md)) | |
| > Results of `SHOW COLLATION` vary when the "new collation framework" is enabled. For new collation framework details, refer to [Character Set and Collation](/character-set-and-collation.md). |
| ## MySQL compatibility | ||
|
|
||
| This statement is understood to be fully compatible with MySQL. Any compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. | ||
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL, the details can be found in [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. |
Contributor
There was a problem hiding this comment.
Suggested change
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL, the details can be found in [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. | |
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL. For details, refer to [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. |
| ## MySQL compatibility | ||
|
|
||
| TiDB does not support collations other than binary. This statement is only provided to ensure compatibility with MySQL. | ||
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL, the details can be found in [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. |
Contributor
There was a problem hiding this comment.
Suggested change
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL, the details can be found in [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. | |
| The usage of this statement is understood to be fully compatible with MySQL. However, charsets in TiDB may have different default collations compared with MySQL. For details, refer to [Compatibility with MySQL](/mysql-compatibility.md). Any other compatibility differences should be [reported via an issue](/report-issue.md) on GitHub. |
Contributor
|
@yikeke, @zimulala, @djshow832, PTAL. |
Contributor
|
@bb7133, please update your pull request. |
- sql-statements/sql-statement-drop-sequence.md - sql-statements/sql-statement-show-character-set.md - sql-statements/sql-statement-show-collation.md
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jun 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2964 |
yikeke
pushed a commit
that referenced
this pull request
Jun 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: bb7133 <bb7133@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?
update several sql statement docs docs-cn#3294