Skip to content

add shutdown statement#2865

Merged
ti-srebot merged 5 commits into
pingcap:masterfrom
jackysp:sw_shutdown
Jun 18, 2020
Merged

add shutdown statement#2865
ti-srebot merged 5 commits into
pingcap:masterfrom
jackysp:sw_shutdown

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Jun 15, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Comment thread sql-statement-shutdown.md
@@ -0,0 +1,35 @@
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this file to TOC.md @jackysp

@yikeke yikeke requested a review from TomShawn June 15, 2020 11:52
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 15, 2020

Please help review this PR. @TomShawn

@TomShawn
Copy link
Copy Markdown
Contributor

Please help review this PR. @TomShawn

OK

Comment thread sql-statement-shutdown.md Outdated
@@ -0,0 +1,35 @@
---
title: SHUTDOWN
summary: Overview of the use of SHUTDOWN in the TiDB database.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: Overview of the use of SHUTDOWN in the TiDB database.
summary: An overview of the usage of SHUTDOWN for the TiDB database.

Comment thread sql-statement-shutdown.md Outdated

## MySQL compatibility

> **Attention:**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Attention:**
> **Note:**

Comment thread sql-statement-shutdown.md Outdated

> **Attention:**
>
> Since TiDB is a distributed database, the shutdown operation in TiDB stops the client-connected TiDB instance, not the entire TiDB cluster.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Since TiDB is a distributed database, the shutdown operation in TiDB stops the client-connected TiDB instance, not the entire TiDB cluster.
> Because TiDB is a distributed database, the shutdown operation in TiDB stops the client-connected TiDB instance, not the entire TiDB cluster.

Comment thread sql-statement-shutdown.md Outdated
>
> Since TiDB is a distributed database, the shutdown operation in TiDB stops the client-connected TiDB instance, not the entire TiDB cluster.

The `SHUTDOWN` statement is partly compatible with MySQL. Any compatibility differences should be [reported via an issue](/report-issue.md) on GitHub.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `SHUTDOWN` statement is partly compatible with MySQL. Any compatibility differences should be [reported via an issue](/report-issue.md) on GitHub.
The `SHUTDOWN` statement is partly compatible with MySQL. If you encounter any compatibility issues, you can report the issues [on GitHub](/report-issue.md).

jackysp added 2 commits June 15, 2020 21:31
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp
Copy link
Copy Markdown
Contributor Author

jackysp commented Jun 15, 2020

PTAL @TomShawn @yikeke

@yikeke yikeke added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jun 18, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit c0fe90c into pingcap:master Jun 18, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #2948

TomShawn pushed a commit that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Jack Yu <yusp@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants