Add Deployment Solutions for Multi-Data Centers in One City#2936
Merged
Conversation
TomShawn
added
translation/from-docs-cn
Contributor
Author
|
@wentaojin PTAL |
lilin90
reviewed
Jun 28, 2020
| aliases: ['/docs/dev/how-to/deploy/geographic-redundancy/overview/','/docs/dev/geo-redundancy-deployment/'] | ||
| --- | ||
|
|
||
| # Deployment Solution for Multiple Data Centers in One City |
Member
There was a problem hiding this comment.
Suggested change
| # Deployment Solution for Multiple Data Centers in One City | |
| # Multiple Data Centers in One City Deployment |
Member
|
Please resolve the conflict. |
Contributor
Author
|
@lilin90 Conflict resolved, PTAL, thanks! |
lilin90
reviewed
Jun 29, 2020
| location_labels = ["zone","dc","rack","host"] | ||
| ``` | ||
|
|
||
| In the example above, `zone` is the logical availability zone level and used to control the isolation of replicas (currently three replicas are in the cluster). |
Member
There was a problem hiding this comment.
Please confirm with the author whether it's level or layer here. level sounds a little bit weird. 🤔
Suggested change
| In the example above, `zone` is the logical availability zone level and used to control the isolation of replicas (currently three replicas are in the cluster). | |
| In the example above, `zone` is the logical availability zone layer that controls the isolation of replicas (three replicas in the example cluster). |
Contributor
Author
There was a problem hiding this comment.
@lilin90 As confirmed with @wentaojin, layer should be used here.
Member
|
@wentaojin PTAL |
lilin90
reviewed
Jun 30, 2020
lilin90
reviewed
Jun 30, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
TomShawn
added
the
requires-version-specific-changes
Contributor
Author
|
@lilin90 All comments are addressed. PTAL again, thanks! |
Member
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3104 |
TomShawn
added a commit
that referenced
this pull request
Jul 1, 2020
…3104) * cherry pick #2936 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Delete geo-redundancy-deployment.md * Update multi-data-centers-in-one-city-deployment.md Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?