Skip to content

Update maintain-tidb-binlog-cluster.md#2974

Merged
ti-srebot merged 2 commits into
masterfrom
update-binlog-doc
Jun 23, 2020
Merged

Update maintain-tidb-binlog-cluster.md#2974
ti-srebot merged 2 commits into
masterfrom
update-binlog-doc

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jun 19, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 19, 2020
@yikeke yikeke added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 19, 2020
@yikeke yikeke requested a review from TomShawn June 19, 2020 11:10
TomShawn
TomShawn approved these changes Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 21, 2020

@TomShawn, PTAL.

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jun 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 23, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit c271a60 into master Jun 23, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 23, 2020
@yikeke @ti-srebot
cherry pick pingcap#2974 to release-4.0
5df072a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 23, 2020

cherry pick to release-4.0 in PR #2996

TomShawn pushed a commit that referenced this pull request Jun 23, 2020
@ti-srebot @yikeke
cherry pick #2974 to release-4.0 (#2996)
fa3d700 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@lilin90 lilin90 deleted the update-binlog-doc branch August 5, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yikeke @ti-srebot @TomShawn