Skip to content

add deprecated warnings for outdated deployment methods#3000

Merged
yikeke merged 4 commits into
masterfrom
add-deprecation-info
Jul 6, 2020
Merged

add deprecated warnings for outdated deployment methods#3000
yikeke merged 4 commits into
masterfrom
add-deprecation-info

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jun 23, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions Bot requested a review from TomShawn June 23, 2020 10:20
@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 23, 2020
@yikeke yikeke added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-2.1 and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 23, 2020
@yikeke yikeke requested review from lilin90 and removed request for TomShawn June 23, 2020 10:21
@ti-srebot
Copy link
Copy Markdown
Contributor

@lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

@lilin90, PTAL.

@yikeke yikeke requested review from lilin90 and removed request for lilin90 June 29, 2020 02:54
@ti-srebot
Copy link
Copy Markdown
Contributor

@lilin90, PTAL.

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@lilin90,Thanks for your review.

Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 6, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@yikeke yikeke merged commit 83ba8b0 into master Jul 6, 2020
@yikeke yikeke deleted the add-deprecation-info branch July 6, 2020 02:46
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-2.1 in PR #3157

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 in PR #3158

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #3159

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3160

ti-srebot added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
yikeke added a commit that referenced this pull request Jul 6, 2020
* cherry pick #3000 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix conflicts

* Update test-deployment-using-docker.md

* Update test-deployment-using-docker.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
yikeke added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke added a commit that referenced this pull request Jul 6, 2020
* cherry pick #3000 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* conflict fix

* Update test-deployment-using-docker.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants