Skip to content

Update grafana tikv dashboard doc#3042

Merged
TomShawn merged 19 commits into
pingcap:masterfrom
Win-Man:tikv-monitor-metrics
Jul 20, 2020
Merged

Update grafana tikv dashboard doc#3042
TomShawn merged 19 commits into
pingcap:masterfrom
Win-Man:tikv-monitor-metrics

Conversation

@Win-Man
Copy link
Copy Markdown
Contributor

@Win-Man Win-Man commented Jun 26, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

@yikeke yikeke requested review from TomShawn and hunterlxt June 28, 2020 02:05
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 28, 2020
Comment thread grafana-tikv-dashboard.md Outdated
This section shows images of the service panels on the TiKV dashboard.

### Cluster
# The metrics description of TiKV
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change Line 2 and Line 3 accordingly.

Suggested change
# The metrics description of TiKV
# Description of TiKV Monitoring Metrics

Comment thread grafana-tikv-dashboard.md Outdated

If you use TiUP to deploy the TiDB cluster, the monitoring system (Prometheus/Grafana) is deployed at the same time. For more information, see [Overview of the Monitoring Framework](/tidb-monitoring-framework.md).

The Grafana dashboard is divided into a series of sub dashboards which include Overview, PD, TiDB, TiKV, Node\_exporter, and so on. A lot of metrics are there to help you diagnose.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Grafana dashboard is divided into a series of sub dashboards which include Overview, PD, TiDB, TiKV, Node\_exporter, and so on. A lot of metrics are there to help you diagnose.
The Grafana dashboard is divided into a series of sub dashboards which include Overview, PD, TiDB, TiKV, Node_exporter, and so on. A lot of metrics are there to help you diagnose.

Comment thread grafana-tikv-dashboard.md Outdated

The Grafana dashboard is divided into a series of sub dashboards which include Overview, PD, TiDB, TiKV, Node\_exporter, and so on. A lot of metrics are there to help you diagnose.

You can get an overview of the component TiKV status from the TiKV dashboard, where the key metrics are displayed. According to the [Performance Map](https://asktug.com/_/tidb-performance-map/#/), you can check whether the status of the cluster is as expected.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can get an overview of the component TiKV status from the TiKV dashboard, where the key metrics are displayed. According to the [Performance Map](https://asktug.com/_/tidb-performance-map/#/), you can check whether the status of the cluster is as expected.
You can get an overview of the component TiKV status from the **TiKV-Details** dashboard, where the key metrics are displayed. According to the [Performance Map](https://asktug.com/_/tidb-performance-map/#/), you can check whether the status of the cluster is as expected.

Comment thread grafana-tikv-dashboard.md Outdated

You can get an overview of the component TiKV status from the TiKV dashboard, where the key metrics are displayed. According to the [Performance Map](https://asktug.com/_/tidb-performance-map/#/), you can check whether the status of the cluster is as expected.

This document provides a detailed description of these key metrics.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document provides a detailed description of these key metrics.
This document provides a detailed description of these key metrics on the **TiKV-Details** dashboard.

Comment thread grafana-tikv-dashboard.md Outdated
- IO utilization:The I/O utilization per TiKV instance
- MBps:The total bytes of read and write in each TiKV instance
- QPS:The QPS per command in each TiKV instance
- Errps:The total number of gRPC message failures
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Errps:The total number of gRPC message failures
- Errps:The rate of gRPC message failures

Comment thread grafana-tikv-dashboard.md Outdated
- Channel full:The number of Channel Full errors per TiKV instance. It should be `0` in normal case.
- Active written leaders:The number of leaders being written on each TiKV instance
- Approximate Region size:The approximate Region size
- Approximate Region size Histogram:The histogram of approximate Region size
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Approximate Region size Histogram:The histogram of approximate Region size
- Approximate Region size Histogram:The histogram of each approximate Region size

Comment thread grafana-tikv-dashboard.md Outdated
- Flush messages per server:The number of Raft messages flushed by each TiKV instance
- Receive messages per server:The number of Raft messages received by each TiKV instance
- Messages:The number of Raft messages sent per type
- Vote:The number of Vote messages sent in Raft
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Vote:The number of Vote messages sent in Raft
- Vote:The number of Vote messages sent in Raft per second

Comment thread grafana-tikv-dashboard.md Outdated
- Receive messages per server:The number of Raft messages received by each TiKV instance
- Messages:The number of Raft messages sent per type
- Vote:The number of Vote messages sent in Raft
- Raft dropped messages:The number of dropped Raft messages per type
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese version says ops, which means operations per second. So please check and align.

Suggested change
- Raft dropped messages:The number of dropped Raft messages per type
- Raft dropped messages:The number of dropped Raft messages per type per second

Comment thread grafana-tikv-dashboard.md Outdated
Comment on lines +125 to +133
- Raft apply proposals per ready:The number of Raft proposals of all Regions per ready handled bucket
- Raft read/write proposals:The number of proposals per type
- Raft read proposals per server:The number of read proposals made by each TiKV instance
- Raft write proposals per server:The number of write proposals made by each TiKV instance
- Propose wait duration:The wait time of each proposal
- Propose wait duration per server:The wait time of each proposal per TiKV instance
- Apply wait duration:The apply time of each proposal
- Apply wait duration per server:The apply time of each proposal per TiKV instance
- Raft log speed:The rate at which peers propose logs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Win-Man This part is not consistent with the Chinese version. Please check and align.

Comment thread grafana-tikv-dashboard.md Outdated
Comment on lines +389 to +393
## 面板常见参数的解释

### gRPC 消息类型

1. 使用事务型接口的命令:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate the Chinese text.

Comment thread grafana-tikv-dashboard.md Outdated
- kv_gc:The command of GC
- kv_delete_range:The command of deleting a continuous piece of data from TiKV

2. 非事务型的裸命令:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first round of review.
Please address the comments first and I'll review for the second round.
@Win-Man

@TomShawn TomShawn added size/large Changes of a large size. status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Jun 28, 2020
@Win-Man
Copy link
Copy Markdown
Contributor Author

Win-Man commented Jun 28, 2020

@TomShawn Thanks for your review, I've fixed what you commented.

@Win-Man
Copy link
Copy Markdown
Contributor Author

Win-Man commented Jun 29, 2020

@TomShawn PTAL

@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

Comment thread grafana-tikv-dashboard.md Outdated
1. Transactional API:

- kv_get:The command of getting the latest version of data specified by ts
- kv_scan:The command of scanning a continuous piece of data
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "a range of data"

Comment thread grafana-tikv-dashboard.md Outdated
- kv_scan_lock:The command of scanning all locks with a version number before `max_version` to clean up expired transactions
- kv_resolve_lock:The command of committing or rollback the transaction lock, according to the transaction status.
- kv_gc:The command of GC
- kv_delete_range:The command of deleting a continuous piece of data from TiKV
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread grafana-tikv-dashboard.md Outdated

- raw_get:The command of getting the value of key
- raw_batch_get:The command of getting the value of batch keys
- raw_scan:The command of scanning a continuous piece of data
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread grafana-tikv-dashboard.md Outdated
- raw_batch_put:The command of writing a batch of key/value pairs
- raw_delete:The command of deleting a key/value pair
- raw_batch_delete:The command of a batch of key/value pairs
- raw_delete_range:The command of deleting a continuous interval
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, use data rather than inerval

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

Win-Man and others added 4 commits July 8, 2020 12:53
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

Comment thread grafana-tikv-dashboard.md
Comment thread grafana-tikv-dashboard.md Outdated
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@hunterlxt PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn, @hunterlxt, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

Copy link
Copy Markdown
Contributor

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread grafana-tikv-dashboard.md Outdated
@ti-srebot
Copy link
Copy Markdown
Contributor

@Win-Man, please update your pull request.

@Win-Man
Copy link
Copy Markdown
Contributor Author

Win-Man commented Jul 18, 2020

@hunterlxt PTAL

@ti-srebot
Copy link
Copy Markdown
Contributor

@hunterlxt,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn merged commit 5b1a811 into pingcap:master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3333

TomShawn pushed a commit that referenced this pull request Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Win-Man <825895587@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants