SQL Tuning: add the page `blocklist-control-plan.md` by winoros · Pull Request #3043 · pingcap/docs

winoros · 2020-06-27T19:44:41Z

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: perf-tuning: add blacklist-control-plan.md docs-cn#3253
Other reference link(s): Optimize description and add missing links docs-cn#3970

yikeke · 2020-06-28T02:11:22Z

The docs-cn PR pingcap/docs-cn#3253 was also cherry-picked to the 3.0 and 3.1 branches. And we
need to align this behavior for this PR? @winoros

winoros · 2020-06-28T07:12:28Z

@yikeke ok, i updated the status.

wwar · 2020-06-28T17:08:28Z

May I suggest renaming from blacklist to block or deny list? See: rails/rails#33677 and https://go-review.googlesource.com/c/go/+/236857/

I realize it might be hard to rename the table mysql.opt_rule_blacklist without causing incompatibility, but the documentation could be a little bit more sensitive.

ilovesoup · 2020-06-29T04:38:23Z

May I suggest renaming from blacklist to block or deny list? See: rails/rails#33677 and https://go-review.googlesource.com/c/go/+/236857/

I realize it might be hard to rename the table mysql.opt_rule_blacklist without causing incompatibility, but the documentation could be a little bit more sensitive.

I agree that we can change document description to blocklist but leave keyword aside for compatibility.

Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>

ti-srebot · 2020-07-01T05:48:08Z

@SunRunAway, @lzmhhh123, @lilin90, PTAL.

ti-srebot · 2020-07-03T05:48:27Z

@SunRunAway, @lzmhhh123, @lilin90, PTAL.

ti-srebot · 2020-07-06T05:48:36Z

@SunRunAway, @lzmhhh123, @lilin90, PTAL.

ti-srebot · 2020-07-15T02:57:03Z

@lzmhhh123,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

lilin90 · 2020-07-15T03:34:30Z

/merge

yikeke · 2020-07-15T03:34:35Z

LGTM

ti-srebot · 2020-07-15T03:35:04Z

/run-all-tests

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-15T03:38:35Z

cherry pick to release-3.0 in PR #3276

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-15T03:40:47Z

cherry pick to release-3.1 in PR #3277

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-15T03:42:24Z

cherry pick to release-4.0 in PR #3278

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Yiding Cui <winoros@gmail.com>

* cherry pick #3043 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Resolve a TOC conflict and add the new file Co-authored-by: Yiding Cui <winoros@gmail.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>

* cherry pick #3043 to release-3.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Resolve a TOC conflict and add the new file Co-authored-by: Yiding Cui <winoros@gmail.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>

winoros added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 27, 2020

winoros force-pushed the blacklist branch 2 times, most recently from 67bae38 to bc5664b Compare June 27, 2020 19:51

SQL Tuning: add the page blacklist-control-plan.md

ac1b73d

winoros force-pushed the blacklist branch from bc5664b to ac1b73d Compare June 27, 2020 19:53

yikeke requested review from lzmhhh123 and yikeke June 28, 2020 02:07

yikeke added the status/PTAL This PR is ready for reviewing. label Jun 28, 2020

yikeke added needs-cherry-pick-3.0 labels Jun 28, 2020

rename blacklist to blocklist

b7bfd63

SunRunAway reviewed Jun 29, 2020

View reviewed changes

Comment thread TOC.md Outdated

Update TOC.md

59273be

Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>

SunRunAway reviewed Jun 29, 2020

View reviewed changes

Comment thread blocklist-control-plan.md Outdated

Update blocklist-control-plan.md

2b541bb

Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>

yikeke requested review from lilin90 and removed request for yikeke June 30, 2020 03:26

lilin90 added the size/large Changes of a large size. label Jul 2, 2020

SE-Bin mentioned this pull request Jul 8, 2020

add topn-limit-push-down #3089

Merged

5 tasks

yikeke mentioned this pull request Jul 10, 2020

perf-tuning: add docs for subquery optimizations #3068

Merged

5 tasks

toutdesuite mentioned this pull request Jul 13, 2020

perf-tuning: add column-prune.md #3246

Merged

5 tasks

yikeke changed the title ~~SQL Tuning: add the page blacklist-control-plan.md~~ SQL Tuning: add the page blocklist-control-plan.md Jul 13, 2020

yikeke approved these changes Jul 15, 2020

View reviewed changes

ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020

ti-srebot approved these changes Jul 15, 2020

View reviewed changes

ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 15, 2020

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020

ti-srebot merged commit e1688b1 into pingcap:master Jul 15, 2020

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 15, 2020

cherry pick pingcap#3043 to release-3.0

137d719

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 15, 2020

SQL Tuning: add the page blocklist-control-plan.md (#3043) #3276

Merged

5 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 15, 2020

cherry pick pingcap#3043 to release-3.1

72453f1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 15, 2020

SQL Tuning: add the page blocklist-control-plan.md (#3043) #3277

Merged

5 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 15, 2020

cherry pick pingcap#3043 to release-4.0

2913d1d

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 15, 2020

SQL Tuning: add the page blocklist-control-plan.md (#3043) #3278

Merged

5 tasks

lilin90 pushed a commit that referenced this pull request Jul 15, 2020

cherry pick #3043 to release-4.0 (#3278)

18dbea9

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Yiding Cui <winoros@gmail.com>

This was referenced Jul 16, 2020

add topn-limit-push-down (#3089) #3284

Merged

add topn-limit-push-down (#3089) #3285

Merged

add topn-limit-push-down (#3089) #3286

Merged

add topn-limit-push-down (#3089) #3287

Merged

This was referenced Jul 17, 2020

perf-tuning: add column-prune.md (#3246) #3316

Merged

perf-tuning: add column-prune.md (#3246) #3317

Merged

perf-tuning: add column-prune.md (#3246) #3318

Merged

perf-tuning: add column-prune.md (#3246) #3319

Merged

Conversation

winoros commented Jun 27, 2020 • edited by lilin90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

yikeke commented Jun 28, 2020

Uh oh!

winoros commented Jun 28, 2020

Uh oh!

wwar commented Jun 28, 2020

Uh oh!

ilovesoup commented Jun 29, 2020

Uh oh!

Uh oh!

Uh oh!

ti-srebot commented Jul 1, 2020

Uh oh!

ti-srebot commented Jul 3, 2020

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

lilin90 commented Jul 15, 2020

Uh oh!

yikeke commented Jul 15, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

winoros commented Jun 27, 2020 •

edited by lilin90

Loading