Skip to content

Create troubleshoot-high-disk-io.md#3046

Merged
ti-srebot merged 54 commits into
masterfrom
King-Dylan-patch-1
Jul 17, 2020
Merged

Create troubleshoot-high-disk-io.md#3046
ti-srebot merged 54 commits into
masterfrom
King-Dylan-patch-1

Conversation

@King-Dylan
Copy link
Copy Markdown
Member

@King-Dylan King-Dylan commented Jun 28, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot requested a review from TomShawn June 28, 2020 03:31
@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 28, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 special-week PR from Document Special Week. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 28, 2020
@TomShawn TomShawn requested a review from TaoZhengCN June 28, 2020 03:45
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 30, 2020

@TaoZhengCN, @TomShawn, PTAL.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 2, 2020

@King-Dylan Please sign the CLA here for this PR to be merged.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 2, 2020

@TaoZhengCN, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first round of review
I'll review for the rest part after the comments are addressed.

Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
Comment thread troubleshoot-high-disk-io.md Outdated
King-Dylan and others added 16 commits July 2, 2020 16:50
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
e5a5a57 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
ff2ee92 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
00898de 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
1d2f95e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
33dc1cc 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
795827a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
0dec9a0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
db0d36e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
98c5132 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
000e623 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
81e9bd3 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
a19112d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
55a145c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
6f7f2b8 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
684446c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan @TomShawn
Update troubleshoot-high-disk-io.md
ce9c7c8 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

@TomShawn, @TaoZhengCN, PTAL.

2 similar comments
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 11, 2020

@TomShawn, @TaoZhengCN, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 14, 2020

@TomShawn, @TaoZhengCN, PTAL.

TomShawn
TomShawn reviewed Jul 16, 2020
View reviewed changes
Comment thread troubleshoot-high-disk-io.md Outdated
TomShawn
TomShawn reviewed Jul 17, 2020
View reviewed changes
Comment thread troubleshoot-high-disk-io.md Outdated
TomShawn
TomShawn reviewed Jul 17, 2020
View reviewed changes
Comment thread troubleshoot-high-disk-io.md Outdated
lilin90
lilin90 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 17, 2020
@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL This PR is ready for reviewing. labels Jul 17, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 17, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 5725608 into master Jul 17, 2020
@TomShawn TomShawn removed the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@King-Dylan @ti-srebot
cherry pick pingcap#3046 to release-4.0
17f117c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-4.0 in PR #3320

TomShawn pushed a commit that referenced this pull request Jul 17, 2020
@ti-srebot @King-Dylan
cherry pick #3046 to release-4.0 (#3320)
05b0a0f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: King-Dylan <50897894+King-Dylan@users.noreply.github.com>
@lilin90 lilin90 deleted the King-Dylan-patch-1 branch July 17, 2020 08:58
@Oreoxmt Oreoxmt mentioned this pull request Apr 26, 2024
Merged
16 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@TaoZhengCN TaoZhengCN Awaiting requested review from TaoZhengCN

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@King-Dylan @CLAassistant @ti-srebot @TomShawn @lilin90