Skip to content

update document of tidb-ctl#3048

Merged
ti-srebot merged 24 commits into
pingcap:masterfrom
imtbkcat:TiDBCtl
Jul 13, 2020
Merged

update document of tidb-ctl#3048
ti-srebot merged 24 commits into
pingcap:masterfrom
imtbkcat:TiDBCtl

Conversation

@imtbkcat
Copy link
Copy Markdown

@imtbkcat imtbkcat commented Jun 28, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from TomShawn, bobotu and yikeke and removed request for TomShawn June 28, 2020 10:38
@yikeke yikeke added needs-cherry-pick-3.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 28, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 28, 2020 •
edited
Loading

Does this PR need to be cherry-picked to release-2.1? @imtbkcat

@imtbkcat
Copy link
Copy Markdown
Author

imtbkcat commented Jun 29, 2020

@yikeke no, it doesn't, some function in release-2.0 is different.

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 29, 2020

@yikeke no, it doesn't, some function in release-2.0 is different.

Sorry, I made a typo. I mean 2.1 (facepalm

@yikeke yikeke requested review from TomShawn and removed request for yikeke June 30, 2020 03:27
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 1, 2020

@bobotu, @TomShawn, PTAL.

@TomShawn TomShawn added the special-week PR from Document Special Week. label Jul 1, 2020
TomShawn
TomShawn suggested changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imtbkcat Please finish the translation from Line 253 in pingcap/docs-cn#3189.

Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md
Comment thread tidb-control.md Outdated
Comment thread tidb-control.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 2, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@TomShawn, @bobotu, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@imtbkcat, please update your pull request.

Lingyu Song and others added 7 commits July 6, 2020 14:34
@TomShawn
Update tidb-control.md
34bbbb9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
83f39b6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
242dd3b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
0600ef8 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
5f1084e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
a5f8292 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update tidb-control.md
2f7b81a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 10, 2020

@TomShawn,Thanks for your review.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 12, 2020

@imtbkcat, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 12, 2020

@TomShawn, @ti-srebot, @bobotu, PTAL.

bobotu
bobotu approved these changes Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

@bobotu, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Jul 13, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 64044c7 into pingcap:master Jul 13, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
@ti-srebot
cherry pick pingcap#3048 to release-3.0
92caf32 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

cherry pick to release-3.0 in PR #3243

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
@ti-srebot
cherry pick pingcap#3048 to release-3.1
b0bdc46 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

cherry pick to release-3.1 in PR #3244

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
@ti-srebot
cherry pick pingcap#3048 to release-4.0
6cd12a9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

cherry pick to release-4.0 in PR #3245

ti-srebot added a commit that referenced this pull request Jul 13, 2020
@ti-srebot
update document of tidb-ctl (#3048) (#3245)
d9568c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 13, 2020

/run-cherry-picker

ti-srebot added a commit that referenced this pull request Jul 13, 2020
@ti-srebot
update document of tidb-ctl (#3048) (#3244)
6e95274 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
@ti-srebot
cherry pick pingcap#3048 to release-2.1
dd5197a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 13, 2020

cherry pick to release-2.1 in PR #3247

ti-srebot added a commit that referenced this pull request Jul 13, 2020
@ti-srebot
update document of tidb-ctl (#3048) (#3243)
e0b17c3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
TomShawn added a commit that referenced this pull request Jul 14, 2020
@ti-srebot @TomShawn
update document of tidb-ctl (#3048) (#3247)
94eb52c 
* cherry pick #3048 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix conflict

* Update tidb-control.md

Co-authored-by: Lingyu Song <songlingyu@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

+2 more reviewers

@bobotu bobotu bobotu approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@imtbkcat @yikeke @ti-srebot @TomShawn @bobotu