Skip to content

update doc for user-defined variables#3056

Merged
DanielZhangQD merged 4 commits into
pingcap:masterfrom
DanielZhangQD:user0
Jun 30, 2020
Merged

update doc for user-defined variables#3056
DanielZhangQD merged 4 commits into
pingcap:masterfrom
DanielZhangQD:user0

Conversation

@DanielZhangQD
Copy link
Copy Markdown
Contributor

@DanielZhangQD DanielZhangQD commented Jun 28, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@DanielZhangQD DanielZhangQD requested review from tangenta and yikeke June 28, 2020 12:29
tangenta
tangenta reviewed Jun 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread user-defined-variables.md Outdated
tangenta
tangenta reviewed Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested review from ran-huang and removed request for yikeke June 29, 2020 06:59
@yikeke yikeke added needs-cherry-pick-3.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 29, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 29, 2020

Please help review this PR~ @ran-huang

ran-huang
ran-huang reviewed Jun 29, 2020
View reviewed changes
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
@DanielZhangQD @ran-huang
Apply suggestions from code review
b63ee29 
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
ran-huang approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 4e68a65 into pingcap:master Jun 30, 2020
@DanielZhangQD DanielZhangQD deleted the user0 branch June 30, 2020 04:07
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 30, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#3056 to release-3.0
8b41b7f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 30, 2020

cherry pick to release-3.0 in PR #3070

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 30, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#3056 to release-3.1
314d72c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 30, 2020

cherry pick to release-3.1 in PR #3072

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 30, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#3056 to release-4.0
9d06d60 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 30, 2020

cherry pick to release-4.0 in PR #3074

ran-huang pushed a commit that referenced this pull request Jun 30, 2020
@ti-srebot @DanielZhangQD
cherry pick #3056 to release-4.0 (#3074)
78a9fe5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
ran-huang pushed a commit that referenced this pull request Jun 30, 2020
@ti-srebot @DanielZhangQD
cherry pick #3056 to release-3.1 (#3072)
8a63cfc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
DanielZhangQD added a commit that referenced this pull request Jun 30, 2020
@ti-srebot @DanielZhangQD
cherry pick #3056 to release-3.0 (#3070)
e4545ba 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta left review comments

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielZhangQD @yikeke @ti-srebot @tangenta @ran-huang