*: update grafana-tidb-dashboard#3067
Merged
Merged
Conversation
zimulala
added
status/PTAL
yikeke
added
status/PTAL
jackysp
reviewed
Jun 30, 2020
Contributor
jackysp
left a comment
jackysp
left a comment
There was a problem hiding this comment.
LGTM, but not sure about the 'words'.
Contributor
1 similar comment
Contributor
TomShawn
reviewed
Jul 6, 2020
TomShawn
reviewed
Jul 8, 2020
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
The second round of review
|
|
||
| - Owner | ||
| - New ETCD Session Duration 95: the time it takes to create a new etcd session. TiDB connects to etcd in PD through etcd client to save/read some metadata information. This records the time spent creating the session | ||
| - Owner Watcher OPS: the number of operations per second of DDL owner watches PD's etcd metadata |
Contributor
There was a problem hiding this comment.
@jackysp The Chinese version DDL owner watch PD 的 etcd 的元数据的 goroutine 的每秒操作次数 is very confusing. Please help check whether the translation here is correct, thanks!
Contributor
1 similar comment
Contributor
TomShawn
reviewed
Jul 13, 2020
Contributor
|
LGTM |
ti-srebot
approved these changes
Jul 14, 2020
TomShawn
reviewed
Jul 14, 2020
Contributor
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
TomShawn
removed
status/LGT1
Contributor
|
/run-cherry-picker |
5 tasks
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #3265 |
ti-srebot
added a commit
that referenced
this pull request
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update TiDB metrics
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?