commit-message: add file: tidb-storage.md#3071
Merged
Merged
Conversation
Signed-off-by: zhouyueyue1115 <1024828678@qq.com>
|
|
yikeke
added
needs-cherry-pick-4.0
status/PTAL
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
1 similar comment
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
TomShawn
reviewed
Jul 10, 2020
TomShawn
reviewed
Jul 10, 2020
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
The first round of review. The rest will be reviewed soon~
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
TomShawn
reviewed
Jul 13, 2020
TomShawn
reviewed
Jul 13, 2020
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
The second round of review.
Contributor
|
@zhouyueyue1115, please update your pull request. |
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
Contributor
|
@zhouyueyue1115, please update your pull request. |
LGTM Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
reviewed
Jul 17, 2020
TomShawn
reviewed
Jul 17, 2020
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
Contributor
|
@zhouyueyue1115, please update your pull request. |
SunRunAway
reviewed
Jul 20, 2020
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
Contributor
|
@SunRunAway Comments addressed, PTAL again, thanks |
Contributor
|
@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
TomShawn
added
require-LGT1
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-4.0 in PR #3340 |
TomShawn
pushed a commit
that referenced
this pull request
Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: zhouyueyue1115 <yueyue.zhou@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouyueyue1115 1024828678@qq.com
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?