Skip to content

update tikv-control.md#3083

Merged
ti-srebot merged 6 commits into
pingcap:masterfrom
gengliqi:update-tikv-control
Jul 16, 2020
Merged

update tikv-control.md#3083
ti-srebot merged 6 commits into
pingcap:masterfrom
gengliqi:update-tikv-control

Conversation

@gengliqi
Copy link
Copy Markdown
Contributor

@gengliqi gengliqi commented Jun 30, 2020

Signed-off-by: Liqi Geng gengliqiii@gmail.com

What is changed, added or deleted? (Required)

Update tikv-control.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@gengliqi
update tikv control
dca1633 
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yikeke yikeke added needs-cherry-pick-3.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@yikeke yikeke requested review from TomShawn and hicqu June 30, 2020 09:19
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 2, 2020

@hicqu, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Jul 2, 2020
View reviewed changes
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
Comment thread tikv-control.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 2, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@TomShawn, @hicqu, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@gengliqi, please update your pull request.

@gengliqi
address comments
a33fe6d 
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
@gengliqi gengliqi requested a review from TomShawn July 6, 2020 08:42
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

@TomShawn, @hicqu, PTAL.

TomShawn
TomShawn reviewed Jul 7, 2020
View reviewed changes
Comment thread tikv-control.md Outdated
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 7, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 7, 2020

LGTM
@hicqu PTAL

@TomShawn TomShawn added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

@TomShawn, @hicqu, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

@gengliqi, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 11, 2020

@TomShawn, @hicqu, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 11, 2020

@gengliqi, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 14, 2020

@TomShawn, @hicqu, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 14, 2020

@gengliqi, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 14, 2020

No updates for a long time, close PR.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

@hicqu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. labels Jul 16, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 8e2239e into pingcap:master Jul 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
@gengliqi @ti-srebot
cherry pick pingcap#3083 to release-3.0
ce3aaa2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

cherry pick to release-3.0 in PR #3295

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
@gengliqi @ti-srebot
cherry pick pingcap#3083 to release-3.1
9df20e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

cherry pick to release-3.1 in PR #3296

TomShawn pushed a commit that referenced this pull request Jul 16, 2020
@ti-srebot @gengliqi
cherry pick #3083 to release-3.0 (#3295)
b7adfe8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
TomShawn pushed a commit that referenced this pull request Jul 16, 2020
@ti-srebot @gengliqi
cherry pick #3083 to release-3.1 (#3296)
252575d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
@gengliqi @ti-srebot
cherry pick pingcap#3083 to release-4.0
fe4e2f5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

cherry pick to release-4.0 in PR #3298

TomShawn pushed a commit that referenced this pull request Jul 16, 2020
@ti-srebot @gengliqi
cherry pick #3083 to release-4.0 (#3298)
7d9737f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hicqu hicqu hicqu approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengliqi @CLAassistant @ti-srebot @TomShawn @hicqu @yikeke