Skip to content

Add docs for RocksDB#3084

Merged
ran-huang merged 11 commits into
pingcap:masterfrom
cosven:docs-rocksdb-overview
Jul 14, 2020
Merged

Add docs for RocksDB#3084
ran-huang merged 11 commits into
pingcap:masterfrom
cosven:docs-rocksdb-overview

Conversation

@cosven
Copy link
Copy Markdown
Contributor

@cosven cosven commented Jun 30, 2020

What is changed, added or deleted? (Required)

Add an introduction to RocksDB.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

@yikeke yikeke requested review from Little-Wallace and lilin90 June 30, 2020 08:52
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@Little-Wallace, @lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

@Little-Wallace, @lilin90, PTAL.

@lilin90 lilin90 requested review from ran-huang and removed request for lilin90 July 7, 2020 03:13
@lilin90 lilin90 added the size/large Changes of a large size. label Jul 7, 2020
Comment thread TOC.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
cosven and others added 2 commits July 8, 2020 22:06
Co-authored-by: Ran <huangran@pingcap.com>
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny details. Rest LGTM.
Very nice translation~ 😃

Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md Outdated
@ran-huang
Copy link
Copy Markdown
Contributor

@Little-Wallace PTAL~

Co-authored-by: Ran <huangran@pingcap.com>
Comment thread rocksdb/rocksdb-overview.md Outdated
Comment thread rocksdb/rocksdb-overview.md
Comment thread rocksdb/rocksdb-overview.md Outdated
@ti-srebot
Copy link
Copy Markdown
Contributor

@ran-huang, @Little-Wallace, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

@ran-huang, @Little-Wallace, PTAL.

Copy link
Copy Markdown

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@Little-Wallace,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ran-huang ran-huang merged commit b15628a into pingcap:master Jul 14, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3264

ran-huang added a commit that referenced this pull request Jul 14, 2020
* cherry pick #3084 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* rm category

Co-authored-by: cosven <cosven@users.noreply.github.com>
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants