Skip to content

en: SQL Prepare Plan Cache#3086

Merged
ti-srebot merged 4 commits into
pingcap:masterfrom
cofyc:prepare-execution-plan-cache
Jul 13, 2020
Merged

en: SQL Prepare Plan Cache#3086
ti-srebot merged 4 commits into
pingcap:masterfrom
cofyc:prepare-execution-plan-cache

Conversation

@cofyc
Copy link
Copy Markdown
Contributor

@cofyc cofyc commented Jun 30, 2020

What is changed, added or deleted? (Required)

English transaction of pingcap/docs-cn#3187.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@cofyc cofyc force-pushed the prepare-execution-plan-cache branch 2 times, most recently from 3a223b3 to 0820a4a Compare June 30, 2020 09:18
@cofyc cofyc force-pushed the prepare-execution-plan-cache branch from 0820a4a to 2c9132d Compare June 30, 2020 09:24
@cofyc cofyc requested review from eurekaka and yikeke June 30, 2020 09:25
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@eurekaka, @yikeke, PTAL.

2 similar comments
@ti-srebot
Copy link
Copy Markdown
Contributor

@eurekaka, @yikeke, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@eurekaka, @yikeke, PTAL.

Comment thread TOC.md Outdated
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 10, 2020

Great and precise translations! I made a commit to improve format and unify doc style. Please leave your comment if you have problems with it. @cofyc

Rest LGTM.

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@cofyc
Copy link
Copy Markdown
Contributor Author

cofyc commented Jul 10, 2020

Great and precise translations! I made a commit to improve format and unify doc style. Please leave your comment if you have problems with it. @cofyc

Rest LGTM.

Thanks for your review!

@ti-srebot
Copy link
Copy Markdown
Contributor

@yikeke, @eurekaka, PTAL.

Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 13, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 3068

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 492d511 into pingcap:master Jul 13, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3248

yikeke pushed a commit that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants