Skip to content

Add scripts to verify anchors in CI#3128

Merged
yikeke merged 3 commits into
masterfrom
add-anchor-check
Jul 3, 2020
Merged

Add scripts to verify anchors in CI#3128
yikeke merged 3 commits into
masterfrom
add-anchor-check

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jul 3, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions Bot requested review from TomShawn and lilin90 July 3, 2020 02:50
@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 3, 2020
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 3, 2020
@yikeke yikeke marked this pull request as draft July 3, 2020 02:51
This was referenced Jul 3, 2020
Merged
Merged
Merged
@yikeke yikeke marked this pull request as ready for review July 3, 2020 04:15
lilin90
lilin90 approved these changes Jul 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
ti-srebot
ti-srebot approved these changes Jul 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 3, 2020

@lilin90,Thanks for your review.

@yikeke yikeke merged commit a10d954 into master Jul 3, 2020
@yikeke yikeke deleted the add-anchor-check branch July 3, 2020 04:49
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3128 to release-4.0
9e7888f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 3, 2020

cherry pick to release-4.0 in PR #3137

yikeke added a commit that referenced this pull request Jul 3, 2020
@yikeke
Add scripts to verify anchors in CI (#3128) (#3130)
0d2bfa4 
* add anchor check to 3.0 branch

* fix 10 anchors

* fix an anchor
yikeke added a commit that referenced this pull request Jul 3, 2020
@yikeke
Add scripts to verify anchors in CI (#3128) (#3131)
c3c5cc8 
* add anchor check to 2.1 branch

* fix 6 anchors
ti-srebot added a commit that referenced this pull request Jul 3, 2020
@ti-srebot
Add scripts to verify anchors in CI (#3128) (#3137)
6f070d9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
yikeke added a commit that referenced this pull request Jul 3, 2020
@yikeke
Add scripts to verify anchors in CI (#3128) (#3129)
b3b4f65 
* add anchor check to 3.1 branch

* fix 11 anchors

* fix an anchor

* Apply suggestions from code review

* fix 2 anchors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

No one assigned

Labels

status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yikeke @ti-srebot @lilin90