reference: update views and constraints#3199
Merged
Merged
Conversation
|
|
ghost
requested review from
Contributor
|
@nullnotnil, @yikeke, @ran-huang, @jackysp, @zz-jason, @XuHuaiyu, PTAL. |
ghost
reviewed
Jul 15, 2020
| --- | ||
|
|
||
| # Constraints | ||
| # Constraint |
There was a problem hiding this comment.
I think this should be plural, since there is more than one type of constraint.
ghost
reviewed
Jul 15, 2020
| COMMIT; | ||
| ``` | ||
|
|
||
| * TiDB does not display foreign key information in the result of executing the `SHOW CREATE TABLE` statement. |
There was a problem hiding this comment.
This may be fixed in pingcap/tidb#18360 before your PR merges. It will still be relevant to TiDB 4.0 and earlier, but not master.
Contributor
There was a problem hiding this comment.
I think this PR can be merged within today. We can update the related content later when #18360 is merged.😄
Contributor
|
@KASSADAR, please update your pull request. |
Contributor
|
No updates for a long time, close PR. |
ran-huang
reviewed
Jul 16, 2020
ran-huang
approved these changes
Jul 16, 2020
Contributor
ran-huang
left a comment
ran-huang
left a comment
There was a problem hiding this comment.
LGTM.
@nullnotnil @zz-jason PTAL. Thanks!
ti-srebot
approved these changes
Jul 16, 2020
ran-huang
added
the
requires-followup
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-3.0 in PR #3313 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-3.1 in PR #3314 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-4.0 in PR #3315 |
ran-huang
pushed a commit
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: KASSADAR <KASSADAR@ALIYUN.COM>
ran-huang
added a commit
that referenced
this pull request
Jul 17, 2020
* cherry pick #3199 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * rm updates in constraints.md Signed-off-by: Ran <huangran@pingcap.com> * resolve conflict Signed-off-by: Ran <huangran@pingcap.com> Co-authored-by: KASSADAR <KASSADAR@ALIYUN.COM> Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
added a commit
that referenced
this pull request
Jul 17, 2020
* cherry pick #3199 to release-3.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * apply version specific changes Signed-off-by: Ran <huangran@pingcap.com> Co-authored-by: KASSADAR <KASSADAR@ALIYUN.COM> Co-authored-by: Ran <huangran@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
For views.md:
For constraints.md:
So when this PR is cherry-picked to 3.1/3.0 branches, the changes to constraints.md should be deleted. Please be aware. @ran-huang
What is the related PR or file link(s)?