Skip to content

Update schema object names#3212

Merged
lilin90 merged 9 commits into
pingcap:masterfrom
Joyinqin:translated-schema-object-names
Jul 17, 2020
Merged

Update schema object names#3212
lilin90 merged 9 commits into
pingcap:masterfrom
Joyinqin:translated-schema-object-names

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Jul 9, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Update schema object names according to the Chinese file: Schema object names

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Joyinqin Joyinqin changed the title schema-object-names Translate-schema-object-names Jul 9, 2020
@yikeke yikeke requested review from lilin90 and tangenta July 9, 2020 08:42
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 9, 2020

/label translation/done,status/PTAL,size/small,needs-cherry-pick-4.0

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 9, 2020
@yikeke yikeke added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.0 and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 9, 2020
@yikeke yikeke mentioned this pull request Jul 9, 2020
Closed
5 tasks
tangenta
tangenta reviewed Jul 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 10, 2020

@tangenta, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 12, 2020

@tangenta, @lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 14, 2020

@tangenta, @lilin90, PTAL.

@lilin90 lilin90 changed the title Translate-schema-object-names Update schema object names Jul 14, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 14, 2020

@Joyinqin Please refer to other PRs to see how to write a title. More reference: Pull Request title style

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 16, 2020

@tangenta, @lilin90, PTAL.

lilin90
lilin90 reviewed Jul 17, 2020
View reviewed changes
Comment thread schema-object-names.md Outdated
Comment thread schema-object-names.md Outdated
Comment thread schema-object-names.md Outdated
Comment thread schema-object-names.md
Comment thread schema-object-names.md Outdated
Comment thread schema-object-names.md Outdated
lilin90
lilin90 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@lilin90 lilin90 merged commit 37acc5a into pingcap:master Jul 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3212 to release-3.0
3a2b2d0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-3.0 in PR #3328

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3212 to release-3.1
9c77c40 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-3.1 in PR #3329

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3212 to release-4.0
b974100 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-4.0 in PR #3330

lilin90 added a commit that referenced this pull request Jul 22, 2020
@ti-srebot @Joyinqin @lilin90
Update schema object names (#3212) (#3328)
c290a4d 
* cherry pick #3212 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update metadata

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90 added a commit that referenced this pull request Jul 22, 2020
@ti-srebot @Joyinqin @lilin90
Update schema object names (#3212) (#3329)
6dd5fa8 
* cherry pick #3212 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update metadata

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90 added a commit that referenced this pull request Jul 22, 2020
@ti-srebot @Joyinqin @lilin90
Update schema object names (#3212) (#3330)
9931a0e 
* cherry pick #3212 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update metadata

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

No one assigned

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Joyinqin @yikeke @ti-srebot @lilin90 @tangenta