Skip to content

Update tidb-specific-system-variables.md#3215

Merged
17 commits merged into
pingcap:masterfrom
ireneontheway:master
Jul 10, 2020
Merged

Update tidb-specific-system-variables.md#3215
17 commits merged into
pingcap:masterfrom
ireneontheway:master

Conversation

@ireneontheway
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Update tidb-specific-system-variables.md to include missing variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ireneontheway
Copy link
Copy Markdown
Contributor Author

/label needs-cherry-pick-4.0,translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 9, 2020
@ireneontheway
Copy link
Copy Markdown
Contributor Author

@yikeke Can you help me review the PR?

@yikeke yikeke requested review from bobotu and yikeke July 10, 2020 03:43
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
@yikeke yikeke added the status/require-change Needs the author to address comments. label Jul 10, 2020
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
Comment thread tidb-specific-system-variables.md Outdated
@yikeke yikeke requested a review from a user July 10, 2020 04:41
@yikeke yikeke mentioned this pull request Jul 10, 2020
22 tasks
@ghost
Copy link
Copy Markdown

ghost commented Jul 10, 2020

The dead anchor check was failing because SHARD_ROW_ID_BITS had been removed. I've added it back in for now. It's wrong, but I will fix it in #3152 after this PR merges.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@nullnotnil, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ghost ghost merged commit e7bf6e2 into pingcap:master Jul 10, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3237

ghost pushed a commit that referenced this pull request Jul 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
@ghost ghost mentioned this pull request Jul 10, 2020
5 tasks
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 10, 2020

The dead anchor check was failing because SHARD_ROW_ID_BITS had been removed. I've added it back in for now. It's wrong, but I will fix it in #3152 after this PR merges.

LGTM

The SHARD_ROW_ID_BITS doc is added back in dev/v4.0 in #3239. Please merge #3239 first before we merge #3152. @nullnotnil

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants