Skip to content

auto-increment: change "continuous" to monotonic (#3584)#3647

Merged
1 commit merged into
pingcap:release-4.0from
ti-srebot:release-4.0-f6a4c02c958b
Aug 13, 2020
Merged

auto-increment: change "continuous" to monotonic (#3584)#3647
1 commit merged into
pingcap:release-4.0from
ti-srebot:release-4.0-f6a4c02c958b

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry-pick #3584 to release-4.0


What is changed, added or deleted? (Required)

The AUTO_INCREMENT doc used the word "continuous" when it should be "monotonic". Continuous means "without any abrupt changes", i.e. at a constant rate (which could be up or down). Auto_increment is not really constant - since restarts could make values jump quite a bit. So could requesting a new batch of cached values.

Monotonic means "either never decreases or never increases". Which is the property it guarantees on a per-server basis.

The language will need version-specific changes because it says "30 thousand by default", but it needs to be 30 thousand explicitly for 2.1 which does not support AUTO_ID_CACHE.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions): will update in another PR because the file does not exist in the earlier three versions. You can check it at the website.
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added requires-followup This PR requires a follow-up task after being merged. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Aug 13, 2020
@ti-srebot ti-srebot requested review from kolbe and lilin90 August 13, 2020 03:19
@ti-srebot ti-srebot assigned ghost Aug 13, 2020
@ghost ghost self-requested a review August 13, 2020 03:28
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ghost ghost merged commit b7a52cf into pingcap:release-4.0 Aug 13, 2020
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants