Skip to content

update tidb v4.0.12 release notes (#5090)#5196

Merged
ti-chi-bot merged 3 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-5f44496115a9
Apr 2, 2021
Merged

update tidb v4.0.12 release notes (#5090)#5196
ti-chi-bot merged 3 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-5f44496115a9

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Apr 2, 2021 •
edited
Loading

cherry-pick #5090 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/5196

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/5196:release-5.0-5f44496115a9

update tidb v4.0.12 release notes

@ti-srebot
cherry pick pingcap#5090 to release-5.0
50c7bd5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2021
Merged
@ti-srebot ti-srebot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Apr 2, 2021
@ti-srebot ti-srebot self-assigned this Apr 2, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Apr 2, 2021

@ti-srebot you're already a collaborator in bot's repo.

@TomShawn TomShawn mentioned this pull request Apr 2, 2021
Merged
11 tasks
TomShawn
TomShawn reviewed Apr 2, 2021
View reviewed changes
Comment thread releases/release-4.0.12.md
TomShawn
TomShawn reviewed Apr 2, 2021
View reviewed changes
Comment thread releases/release-4.0.12.md
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 2, 2021

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 2, 2021

@TomShawn: /merge in this pull request requires 1 /lgtm.

Details

In response to this:

/unhold
/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 2, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 2, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 2, 2021

/unhold
/label needs-cherry-pick-master

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2021
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Apr 2, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 2, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 2, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f5a1c70

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2021
@ti-chi-bot ti-chi-bot merged commit 97069e7 into pingcap:release-5.0 Apr 2, 2021
ti-srebot added a commit to ti-srebot/docs that referenced this pull request Apr 2, 2021
@ti-srebot
cherry pick pingcap#5196 to master
4726b4c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Apr 2, 2021

cherry pick to master in PR #5201

@TomShawn TomShawn deleted the release-5.0-5f44496115a9 branch April 2, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

@nolouch nolouch Awaiting requested review from nolouch

@overvenus overvenus Awaiting requested review from overvenus

@qiancai qiancai Awaiting requested review from qiancai

@qw4990 qw4990 Awaiting requested review from qw4990

@solotzg solotzg Awaiting requested review from solotzg

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ti-srebot ti-srebot

Labels

needs-cherry-pick-master Should cherry pick this PR to master branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @TomShawn @ti-chi-bot